From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lists.gentoo.org ([140.105.134.102] helo=robin.gentoo.org) by nuthatch.gentoo.org with esmtp (Exim 4.67) (envelope-from ) id 1IENjJ-0000IL-Dd for garchives@archives.gentoo.org; Fri, 27 Jul 2007 11:11:33 +0000 Received: from robin.gentoo.org (localhost [127.0.0.1]) by robin.gentoo.org (8.14.0/8.14.0) with SMTP id l6RBAb5M022171; Fri, 27 Jul 2007 11:10:37 GMT Received: from hansmi.home.forkbomb.ch (hansmi.home.forkbomb.ch [213.144.146.165]) by robin.gentoo.org (8.14.0/8.14.0) with ESMTP id l6RB8aJ5019751 for ; Fri, 27 Jul 2007 11:08:36 GMT Received: (qmail 19175 invoked by uid 1000); 27 Jul 2007 11:08:36 -0000 Date: Fri, 27 Jul 2007 13:08:36 +0200 From: Michael Hanselmann To: Benedikt Boehm Cc: gentoo-dev@lists.gentoo.org Subject: Re: [gentoo-dev] [RFC] qmail.eclass draft Message-ID: <20070727110836.GA16350@hansmi.ch> References: <20070713133711.5ef6fc6a@zeus.home.xnull.de> <20070720095202.GC25920@hansmi.ch> <20070723215817.721169ea@zeus.home.xnull.de> Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="C7zPtVaVf+AK4Oqc" Content-Disposition: inline In-Reply-To: <20070723215817.721169ea@zeus.home.xnull.de> User-Agent: Mutt/1.5.13 (2006-08-11) X-Archives-Salt: 9abfbab8-b2a2-452e-9309-e593cc855251 X-Archives-Hash: 740a84adb7183a5a66299329f060dc0d --C7zPtVaVf+AK4Oqc Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hello Benedikt Sorry for my long response times. On Mon, Jul 23, 2007 at 09:58:17PM +0200, Benedikt Boehm wrote: > i thought about this, but i'd really like to see things like qmail-spp > and the gentoo qmail tarball be handled by the eclass, on the other > hand i agree that unpacking netqmail or qmail based on $FOO is not the > best idea. any suggestions? I really don't see the point of having qmail_spp_src_unpack and all of these qmail-spp related variables. There have to be different diffs anyway for other sources, making it more complicated with that many variables. Aren't you overengineering here? Now some things I noticed while going through, in no special order: - Why need_qmail? It slows down cache regeneration and is really unneeded. - In qmail_man_install you rename some manpages. Can you please add a comment on why you do this? - You're very inconsistent with variable quoting. Please quote them everywhere except the places where you're absolutly sure there will be no spaces (or other special characters) in them. Maybe the original netqmail has some of these issues, too, but now we can fix them. - Don't align stuff like on the last two lines in qmail_src_install. - The "use gencertdaily" thing in qmail_ssl_generate works, but doesn't look so nice. How about this? use gencertdaily && \ CRON_FOLDER=3Dcron.daily || \ CRON_FOLDER=3Dcron.hourly - Limit line length to 80 characters (with tabs at 8 spaces). - I don't like the custom tarball. How do you want to build and redistribute it without depending on a single person? Its sources need to reside completly on Gentoo infrastructure. - If I remember correctly, elog shouldn't be used for empty lines like in qmail_supervise_config_notice. Use echo instead for them. So, now you should have something to chew on again. :-) Thanks, Michael --=20 http://hansmi.ch/ --C7zPtVaVf+AK4Oqc Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.7 (GNU/Linux) iD8DBQFGqdI06J0saEpRu+oRAqInAJsFMa/y/pjT15wJ9R7bz9M4qYbMhQCfcHmR Omtp1TzaOnjMt4kn7QAgoXw= =wzgS -----END PGP SIGNATURE----- --C7zPtVaVf+AK4Oqc-- -- gentoo-dev@gentoo.org mailing list