From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lists.gentoo.org ([140.105.134.102] helo=robin.gentoo.org) by nuthatch.gentoo.org with esmtp (Exim 4.62) (envelope-from ) id 1IBpCN-0001xR-8s for garchives@archives.gentoo.org; Fri, 20 Jul 2007 09:54:59 +0000 Received: from robin.gentoo.org (localhost [127.0.0.1]) by robin.gentoo.org (8.14.0/8.14.0) with SMTP id l6K9s0CF007374; Fri, 20 Jul 2007 09:54:00 GMT Received: from hansmi.home.forkbomb.ch (hansmi.home.forkbomb.ch [213.144.146.165]) by robin.gentoo.org (8.14.0/8.14.0) with ESMTP id l6K9q3Pc005135 for ; Fri, 20 Jul 2007 09:52:03 GMT Received: (qmail 28037 invoked by uid 1000); 20 Jul 2007 09:52:02 -0000 Date: Fri, 20 Jul 2007 11:52:02 +0200 From: Michael Hanselmann To: gentoo-dev@lists.gentoo.org Cc: hollow@gentoo.org Subject: Re: [gentoo-dev] [RFC] qmail.eclass draft Message-ID: <20070720095202.GC25920@hansmi.ch> References: <20070713133711.5ef6fc6a@zeus.home.xnull.de> Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="69pVuxX8awAiJ7fD" Content-Disposition: inline In-Reply-To: <20070713133711.5ef6fc6a@zeus.home.xnull.de> User-Agent: Mutt/1.5.13 (2006-08-11) X-Archives-Salt: 4f190945-1b61-4a2c-b029-3d824c7b334a X-Archives-Hash: 999c6f253e118df8e4ca870fb454c1c0 --69pVuxX8awAiJ7fD Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hello Benedikt On Fri, Jul 13, 2007 at 01:37:11PM +0200, Benedikt Boehm wrote: > It is basically netqmail split into much smaller chunks so they can be > reused by other qmail variants as well. Okay, I looked through it and found some things which need reconsideration. I agree that user creation and such things can be easily done in an eclass. However, functions like qmail_src_unpack should be done in the ebuild. Putting them in an eclass and just doing "if (a) { =E2=80=A6 } else if (b) { =E2=80=A6 }" makes it harder to underst= and and unneccessarily complicated. qmail_base_install should be split in smaller functions, maybe with callbacks (if possible in bash). In the end the ebuild shouldn't contain any package-specific code. Can you look into it again? Greets, Michael --=20 http://hansmi.ch/ --69pVuxX8awAiJ7fD Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.7 (GNU/Linux) iD8DBQFGoIXC6J0saEpRu+oRAoOFAJ0VHMbLvVWPZUdE50a2hcGbfILbOwCeK5BP fG9LzK5/dpOG6pBKjQD8+HE= =oko9 -----END PGP SIGNATURE----- --69pVuxX8awAiJ7fD-- -- gentoo-dev@gentoo.org mailing list