From: Michael Hanselmann <hansmi@gentoo.org>
To: gentoo-dev@lists.gentoo.org
Cc: hollow@gentoo.org
Subject: Re: [gentoo-dev] [RFC] qmail.eclass draft
Date: Fri, 20 Jul 2007 11:52:02 +0200 [thread overview]
Message-ID: <20070720095202.GC25920@hansmi.ch> (raw)
In-Reply-To: <20070713133711.5ef6fc6a@zeus.home.xnull.de>
[-- Attachment #1: Type: text/plain, Size: 816 bytes --]
Hello Benedikt
On Fri, Jul 13, 2007 at 01:37:11PM +0200, Benedikt Boehm wrote:
> It is basically netqmail split into much smaller chunks so they can be
> reused by other qmail variants as well.
Okay, I looked through it and found some things which need
reconsideration. I agree that user creation and such things can be
easily done in an eclass. However, functions like qmail_src_unpack
should be done in the ebuild. Putting them in an eclass and just doing
"if (a) { … } else if (b) { … }" makes it harder to understand and
unneccessarily complicated. qmail_base_install should be split in
smaller functions, maybe with callbacks (if possible in bash). In the
end the ebuild shouldn't contain any package-specific code. Can you look
into it again?
Greets,
Michael
--
http://hansmi.ch/
[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]
next prev parent reply other threads:[~2007-07-20 9:54 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-13 11:37 [gentoo-dev] [RFC] qmail.eclass draft Benedikt Boehm
2007-07-13 12:34 ` Michael Hanselmann
2007-07-13 12:53 ` Jakub Moc
2007-07-13 15:22 ` William L. Thomson Jr.
2007-07-13 17:05 ` Benedikt Boehm
2007-07-14 20:56 ` Michael Hanselmann
2007-07-14 21:09 ` Michael Hanselmann
2007-07-13 13:04 ` Benedikt Boehm
2007-07-14 21:02 ` Michael Hanselmann
2007-07-15 1:07 ` Benedikt Boehm
2007-07-15 11:19 ` Michael Hanselmann
2007-07-15 19:26 ` Benedikt Boehm
2007-07-13 14:37 ` Petteri Räty
2007-07-14 20:52 ` Michael Hanselmann
2007-07-20 9:52 ` Michael Hanselmann [this message]
2007-07-20 20:05 ` Benedikt Boehm
2007-07-20 21:17 ` Michael Hanselmann
2007-07-23 19:55 ` Benedikt Boehm
2007-07-24 9:42 ` Benedikt Boehm
2007-07-23 19:58 ` Benedikt Boehm
2007-07-27 11:08 ` Michael Hanselmann
2007-07-28 2:04 ` Marius Mauch
2007-07-28 5:51 ` [gentoo-dev] " Steve Long
2007-07-30 11:20 ` [gentoo-dev] " Benedikt Boehm
2007-07-30 12:23 ` Michael Hanselmann
2007-07-30 14:51 ` Benedikt Boehm
2007-07-30 15:56 ` Michael Hanselmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070720095202.GC25920@hansmi.ch \
--to=hansmi@gentoo.org \
--cc=gentoo-dev@lists.gentoo.org \
--cc=hollow@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox