From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lists.gentoo.org ([140.105.134.102] helo=robin.gentoo.org) by nuthatch.gentoo.org with esmtp (Exim 4.60) (envelope-from ) id 1G2cpm-0003U5-PP for garchives@archives.gentoo.org; Mon, 17 Jul 2006 23:49:07 +0000 Received: from robin.gentoo.org (localhost [127.0.0.1]) by robin.gentoo.org (8.13.7/8.13.6) with SMTP id k6HNm7M4015158; Mon, 17 Jul 2006 23:48:07 GMT Received: from mail.isohunt.com (mail.isohunt.com [69.64.61.20]) by robin.gentoo.org (8.13.7/8.13.6) with ESMTP id k6HNjkO1010150 for ; Mon, 17 Jul 2006 23:45:47 GMT Received: (qmail 16124 invoked from network); 17 Jul 2006 18:45:46 -0500 Received: from Unknown (HELO curie.orbis-terrarum.net) (24.81.201.182) (smtp-auth username robbat2@isohunt.com, mechanism login) by mail.isohunt.com (qpsmtpd/0.33-dev on w2.isohunt.com) with (AES256-SHA encrypted) ESMTP; Mon, 17 Jul 2006 18:45:46 -0500 Received: (qmail 32062 invoked by uid 10000); 17 Jul 2006 16:45:42 -0700 Date: Mon, 17 Jul 2006 16:45:42 -0700 From: "Robin H. Johnson" To: gentoo-dev@lists.gentoo.org Subject: Re: [gentoo-dev] Making dobin, doexe, doins, doman, dodoc die by default Message-ID: <20060717234542.GE16219@curie-int.orbis-terrarum.net> Mail-Followup-To: gentoo-dev@lists.gentoo.org References: <200607132332.40496.vapier@gentoo.org> <20060717151445.GA14415@mustard.flatmonk> <200607171800.05315.vapier@gentoo.org> Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@gentoo.org Reply-to: gentoo-dev@lists.gentoo.org Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="FeAIMMcddNRN4P4/" Content-Disposition: inline In-Reply-To: <200607171800.05315.vapier@gentoo.org> User-Agent: Mutt/1.5.11 X-Archives-Salt: 0baa2828-0009-4fc1-bac1-d06c1c415037 X-Archives-Hash: c1fcb4e55cde8d08051930a95b76aa1b --FeAIMMcddNRN4P4/ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jul 17, 2006 at 06:00:04PM -0400, Mike Frysinger wrote: > at this point i'm against it due to the loss of information/granularity i= n the=20 > die message ... and utilizing DIE_MSG is garbage >=20 > if die can be made more useful, then i'd be for the do* functions calling= die=20 > for me > -mike How about changing the internals of dobin etc to behave like this (puesdo-code): in ebuild: dobin xyz in dobin code: (existing stuff) [ (check failure) ] && die "Failure: dobin $@" So if 'dobin xyz' fails, you get a die, with the message of "Failure: dobin xyz" This hooks nicely into the existing stacktrace: !!! ERROR: dev-lang/php-5.1.4-r1 failed. Call stack: ebuild.sh, line XXX: Called dyn_install ebuild.sh, line XXX: Called src_install php-5.1.4-r1.ebuild, line XXX: Called php5_1-sapi_src_install php5_1-sapi.eclass, line XXX: Called dobin dobin, line XXX: called die Additionally, keep DIE_MSG support for anybody that wants to override the default messages. --=20 Robin Hugh Johnson E-Mail : robbat2@gentoo.org GnuPG FP : 11AC BA4F 4778 E3F6 E4ED F38E B27B 944E 3488 4E85 --FeAIMMcddNRN4P4/ Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.4 (GNU/Linux) Comment: Robbat2 @ Orbis-Terrarum Networks iD8DBQFEvCEmPpIsIjIzwiwRAh4VAJ4/H5MP7DkENuDuei6gfwPvg+WvhQCeOBJP ihNNM4gbV3bdMce9hr8zh7k= =WmEZ -----END PGP SIGNATURE----- --FeAIMMcddNRN4P4/-- -- gentoo-dev@gentoo.org mailing list