From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lists.gentoo.org ([140.105.134.102] helo=robin.gentoo.org) by nuthatch.gentoo.org with esmtp (Exim 4.60) (envelope-from ) id 1FxarW-0002ve-Rw for garchives@archives.gentoo.org; Tue, 04 Jul 2006 02:42:07 +0000 Received: from robin.gentoo.org (localhost [127.0.0.1]) by robin.gentoo.org (8.13.7/8.13.6) with SMTP id k642ePLU021923; Tue, 4 Jul 2006 02:40:25 GMT Received: from mail.net-conex.com (pops.net-conex.com [204.244.176.3]) by robin.gentoo.org (8.13.7/8.13.6) with ESMTP id k642audb015378 for ; Tue, 4 Jul 2006 02:36:56 GMT Received: from curie.orbis-terrarum.net (S01060050da688d47.vc.shawcable.net [24.80.100.253]) by mail.net-conex.com (8.13.4/8.12.11) with ESMTP id k642atZ3022196 for ; Mon, 3 Jul 2006 19:36:55 -0700 Received: (qmail 19373 invoked by uid 10000); 3 Jul 2006 19:36:56 -0700 Date: Mon, 3 Jul 2006 19:36:56 -0700 From: "Robin H. Johnson" To: gentoo-dev@lists.gentoo.org Subject: Re: [gentoo-dev] pkg_nofetch: $A vs. $SRC_URI Message-ID: <20060704023656.GC10574@curie-int.vc.shawcable.net> Mail-Followup-To: gentoo-dev@lists.gentoo.org References: <20060704010015.GA10574@curie-int.vc.shawcable.net> <44A9CECF.3090501@gentoo.org> Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@gentoo.org Reply-to: gentoo-dev@lists.gentoo.org Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="oJ71EGRlYNjSvfq7" Content-Disposition: inline In-Reply-To: <44A9CECF.3090501@gentoo.org> User-Agent: Mutt/1.5.11 X-Archives-Salt: 318be497-8788-4634-998b-52a325a13884 X-Archives-Hash: 9bb839facc77ebe205b2742f2ee35740 --oJ71EGRlYNjSvfq7 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jul 03, 2006 at 07:13:35PM -0700, Donnie Berkholz wrote: > Robin H. Johnson wrote: > > If you have an ebuild with a non-standard pkg_nofetch, please ensure > > that you use $SRC_URI instead of $A! > >=20 > > This is because if you have FEATURES=3Dmirror or FEATURES=3Dcvs, attemp= ts to > > download all of the source files for digesting or verification will hit > > pkg_nofetch and $A is only the subset of $SRC_URI, causing misleading > > messages to be displayed about what needs to be downloaded still. > >=20 > > Plasmaroo: could you perhaps change this in the devmanual? > >=20 > > I'll be looking through the tree to fix any existing occurrences of thi= s. > Displaying $SRC_URI is worse for the user, because it displays this > weird dependency tree containing USE flags that they should not need to > decipher. >=20 > I don't consider this something that should be "fixed." In that case, neither behavior is correct. Additionally, you should talk to the portage team and get the master ebuild.sh changed, because the stock pkg_nofetch there uses SRC_URI. This is the existing default pkg_nofetch from ebuild.sh: pkg_nofetch() { [ -z "${SRC_URI}" ] && return echo "!!! The following are listed in SRC_URI for ${PN}:" local x for x in $(echo ${SRC_URI}); do echo "!!! ${x}" done } When FEATURES=3Dmirror, and you try to fetch, it does indeed contain uneval= uated USE flags. However for FEATURES=3D-mirror, the content of it is correct - n= o USE flags at all. Maybe a two-part solution is in order here then: 1. Change portage behavior regarding the value of SRC_URI during fetch with FEATURES=3Dmirror to not contain any conditionals. 2. Change all ebuilds to use SRC_URI in pkg_nofetch --=20 Robin Hugh Johnson E-Mail : robbat2@gentoo.org GnuPG FP : 11AC BA4F 4778 E3F6 E4ED F38E B27B 944E 3488 4E85 --oJ71EGRlYNjSvfq7 Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.4 (GNU/Linux) Comment: Robbat2 @ Orbis-Terrarum Networks iD8DBQFEqdRIPpIsIjIzwiwRArqVAKCKwP4lXae9aZEzTHDTK/AjvoPifQCcDVjs hcqEd02vgBgtQFkSCefkLVk= =WQTT -----END PGP SIGNATURE----- --oJ71EGRlYNjSvfq7-- -- gentoo-dev@gentoo.org mailing list