From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lists.gentoo.org ([140.105.134.102] helo=robin.gentoo.org) by nuthatch.gentoo.org with esmtp (Exim 4.54) id 1F3Dmc-00005Y-JJ for garchives@archives.gentoo.org; Sun, 29 Jan 2006 14:44:03 +0000 Received: from robin.gentoo.org (localhost [127.0.0.1]) by robin.gentoo.org (8.13.5/8.13.5) with SMTP id k0TEgi7K021923; Sun, 29 Jan 2006 14:42:44 GMT Received: from smtp.gentoo.org (smtp.gentoo.org [134.68.220.30]) by robin.gentoo.org (8.13.5/8.13.5) with ESMTP id k0TEdw71020012 for ; Sun, 29 Jan 2006 14:39:59 GMT Received: from localhost ([127.0.0.1] helo=home.wh0rd.org) by smtp.gentoo.org with esmtp (Exim 4.54) id 1F3Dig-0001BH-Gi for gentoo-dev@lists.gentoo.org; Sun, 29 Jan 2006 14:39:58 +0000 Received: (qmail 3926 invoked from network); 29 Jan 2006 09:31:38 -0500 Received: from unknown (HELO vapier) (192.168.0.2) by 192.168.0.1 with SMTP; 29 Jan 2006 09:31:38 -0500 From: Mike Frysinger Organization: wh0rd.org To: gentoo-dev@lists.gentoo.org Subject: Re: "Environement categories" (was Re: [gentoo-dev] fix binary debug support, part elevenity billion 1/2) Date: Sun, 29 Jan 2006 09:40:12 -0500 User-Agent: KMail/1.9 References: <200601150111.54995.vapier@gentoo.org> <200601242006.12113.vapier@gentoo.org> <20060125072601.GA8041@nightcrawler.had1.or.comcast.net> In-Reply-To: <20060125072601.GA8041@nightcrawler.had1.or.comcast.net> Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 Content-Type: Multipart/Mixed; boundary="Boundary-00=_MPN3DsFIvyAnDvr" Message-Id: <200601290940.12249.vapier@gentoo.org> X-Archives-Salt: 8f9b8b9e-9764-470f-80bb-fa47923e4f4a X-Archives-Hash: 8bc8ddf83ddaf61a634c5579a945e7a2 --Boundary-00=_MPN3DsFIvyAnDvr Content-Type: text/plain; charset="iso-8859-6" Content-Transfer-Encoding: 7bit Content-Disposition: inline On Wednesday 25 January 2006 02:26, Brian Harring wrote: > On Tue, Jan 24, 2006 at 08:06:12PM -0500, Mike Frysinger wrote: > > i would be ok with implementing the back end (i.e. FEATURES=debug-build) > > but putting off the front end (i.e. emerge --debug-build) > > Front-end doesn't matter, it's the back-end that's the concern. Clean > up the backend in stable, and it's fine- hence the "shelve it"; fix > the backend instead of tagging it half way in. what exactly is "half way" about the attached patch ? -mike --Boundary-00=_MPN3DsFIvyAnDvr Content-Type: text/x-diff; charset="iso-8859-6"; name="portage-debug-build-backend.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="portage-debug-build-backend.patch" Index: pym/portage.py =================================================================== --- pym/portage.py (revision 2604) +++ pym/portage.py (working copy) @@ -1263,6 +1263,23 @@ if "usersandbox" in self.features: self.features.remove("usersandbox") + if "debug-build" in self.features: + # the profile should be setting these, but just in case ... + if not len(self["DEBUG_CFLAGS"]): + self["DEBUG_CFLAGS"] = "-g -O" + self.backup_changes("DEBUG_CFLAGS") + if not len(self["DEBUG_CXXFLAGS"]): + self["DEBUG_CXXFLAGS"] = self["DEBUG_CFLAGS"] + self.backup_changes("DEBUG_CXXFLAGS") + # replace user vars with debug version + for var in ["CFLAGS","CXXFLAGS","LDFLAGS"]: + self[var]=self["DEBUG_"+var] + self.backup_changes(var) + # if user has splitdebug, the debug info will be auto saved for + # gdb, otherwise we want to keep the binaries from being stripped + if not "splitdebug" in self.features: + self.features.append("nostrip") + self.features.sort() self["FEATURES"] = " ".join(["-*"]+self.features) self.backup_changes("FEATURES") Index: pym/portage_const.py =================================================================== --- pym/portage_const.py (revision 2604) +++ pym/portage_const.py (working copy) @@ -40,7 +40,7 @@ CONFIG_MEMORY_FILE = PRIVATE_PATH + "/config" INCREMENTALS=["USE","USE_EXPAND","USE_EXPAND_HIDDEN","FEATURES","ACCEPT_KEYWORDS","ACCEPT_LICENSE","CONFIG_PROTECT_MASK","CONFIG_PROTECT","PRELINK_PATH","PRELINK_PATH_MASK"] -STICKIES=["KEYWORDS_ACCEPT","USE","CFLAGS","CXXFLAGS","MAKEOPTS","EXTRA_ECONF","EXTRA_EINSTALL","EXTRA_EMAKE"] +STICKIES=["KEYWORDS_ACCEPT","USE","CFLAGS","CXXFLAGS","LDFLAGS","DEBUG_CFLAGS","DEBUG_CXXFLAGS","DEBUG_LDFLAGS","MAKEOPTS","EXTRA_ECONF","EXTRA_EINSTALL","EXTRA_EMAKE"] EBUILD_PHASES = ["setup","unpack","compile","test","install","preinst","postinst","prerm","postrm"] EAPI = 0 --Boundary-00=_MPN3DsFIvyAnDvr-- -- gentoo-dev@gentoo.org mailing list