[gentoo-dev] $BUILDDIR in ebuilds

[gentoo-dev] $BUILDDIR in ebuilds

[Brian Harring]

[-- Attachment #1: Type: text/plain, Size: 174 bytes --]

Hola all.

Just sending a notice/reminder that ebuilds should not be using 
$BUILDDIR directly- especially since vapier just commited a rename of 
that var.

~harring

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]

[gentoo-dev] Re: $BUILDDIR in ebuilds

[Michael Sterrett -Mr. Bones.-]

Like in here?

app-doc/halibut/halibut-0.9.ebuild:           BUILDDIR="${S}/build" \
net-dns/maradns/maradns-1.0.27.ebuild:                BUILDDIR=${S}/build \
net-dns/maradns/maradns-1.0.32.ebuild:                BUILDDIR=${S}/build \

Michael Sterrett
   -Mr. Bones.-
mr_bones_@gentoo.org

On Sun, 25 Dec 2005, Brian Harring wrote:

> Hola all.
>
> Just sending a notice/reminder that ebuilds should not be using
> $BUILDDIR directly- especially since vapier just commited a rename of
> that var.
>
> ~harring
>
-- 
gentoo-dev@gentoo.org mailing list

Re: [gentoo-dev] Re: $BUILDDIR in ebuilds

[Brian Harring]

[-- Attachment #1: Type: text/plain, Size: 715 bytes --]


On Mon, Dec 26, 2005 at 02:51:26AM -0500, Michael Sterrett -Mr. Bones.- wrote:
> Like in here?
> 
> app-doc/halibut/halibut-0.9.ebuild:           BUILDDIR="${S}/build" \
> net-dns/maradns/maradns-1.0.27.ebuild:                BUILDDIR=${S}/build \
> net-dns/maradns/maradns-1.0.32.ebuild:                BUILDDIR=${S}/build \

Actually, calls of that sort is why it's being changed.
They're not relying on portage supplied BUILDDIR location, they're 
defining it as an arg to make- the problem is that portage supplied 
BUILDDIR has the potential to get used by make.

Either way, those 3 are fine- they're not relying on portage provided 
BUILDDIR var, just issueing a directive to make.
~harring

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]

Re: [gentoo-dev] Re: $BUILDDIR in ebuilds

[Drake Wyrm]

[-- Attachment #1: Type: text/plain, Size: 783 bytes --]

Brian Harring <ferringb@gentoo.org> wrote:
> 
> On Mon, Dec 26, 2005 at 02:51:26AM -0500, Michael Sterrett -Mr. Bones.- wrote:
> > Like in here?
> > 
> > app-doc/halibut/halibut-0.9.ebuild:           BUILDDIR="${S}/build" \
> > net-dns/maradns/maradns-1.0.27.ebuild:                BUILDDIR=${S}/build \
> > net-dns/maradns/maradns-1.0.32.ebuild:                BUILDDIR=${S}/build \
[snip]
> Either way, those 3 are fine- they're not relying on portage provided 
> BUILDDIR var, just issueing a directive to make.

In that case, shouldn't they use something like BUILDDIR="$BUILDDIR" to
supply the argument to make?

-- 
That is not dead which can eternal lie,
And with strange eons even death may die.
  -- The Call of Cthulu, II. The Tale of Inspector Legrasse

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]

Re: [gentoo-dev] Re: $BUILDDIR in ebuilds

[Mike Frysinger]

On Monday 26 December 2005 08:24, Drake Wyrm wrote:
> Brian Harring <ferringb@gentoo.org> wrote:
> > On Mon, Dec 26, 2005 at 02:51:26AM -0500, Michael Sterrett -Mr. Bones.- 
wrote:
> > > Like in here?
> > >
> > > app-doc/halibut/halibut-0.9.ebuild:           BUILDDIR="${S}/build" \
> > > net-dns/maradns/maradns-1.0.27.ebuild:               
> > > BUILDDIR=${S}/build \ net-dns/maradns/maradns-1.0.32.ebuild:           
> > >     BUILDDIR=${S}/build \
>
> [snip]
>
> > Either way, those 3 are fine- they're not relying on portage provided
> > BUILDDIR var, just issueing a directive to make.
>
> In that case, shouldn't they use something like BUILDDIR="$BUILDDIR" to
> supply the argument to make?

that is how they're being used :P
-mike
-- 
gentoo-dev@gentoo.org mailing list