From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lists.gentoo.org ([140.105.134.102] helo=robin.gentoo.org) by nuthatch.gentoo.org with esmtp (Exim 4.54) id 1Eqg1D-0004Af-Jb for garchives@archives.gentoo.org; Mon, 26 Dec 2005 00:15:16 +0000 Received: from robin.gentoo.org (localhost [127.0.0.1]) by robin.gentoo.org (8.13.5/8.13.5) with SMTP id jBQ0EX9M032492; Mon, 26 Dec 2005 00:14:33 GMT Received: from smtp.gentoo.org (smtp.gentoo.org [134.68.220.30]) by robin.gentoo.org (8.13.5/8.13.5) with ESMTP id jBQ0CfS4017320 for ; Mon, 26 Dec 2005 00:12:42 GMT Received: from zb101200.ppp.dion.ne.jp ([219.125.101.200] helo=opteron246.suzuki-stubbs.home) by smtp.gentoo.org with esmtpa (Exim 4.54) id 1Eqfyj-0007k8-DS for gentoo-dev@lists.gentoo.org; Mon, 26 Dec 2005 00:12:41 +0000 Received: by opteron246.suzuki-stubbs.home (Postfix, from userid 1000) id 324CE201AC9; Mon, 26 Dec 2005 09:13:40 +0900 (JST) From: Jason Stubbs To: gentoo-dev@lists.gentoo.org Subject: Re: [gentoo-dev] making dodoc and dohtml die when they fail and stricter is on Date: Mon, 26 Dec 2005 09:13:39 +0900 User-Agent: KMail/1.9 References: <43AF2BF5.4060905@gentoo.org> In-Reply-To: <43AF2BF5.4060905@gentoo.org> Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Message-Id: <200512260913.39975.jstubbs@gentoo.org> X-MIME-Autoconverted: from quoted-printable to 8bit by robin.gentoo.org id jBQ0CfS4017320 Content-Transfer-Encoding: quoted-printable X-MIME-Autoconverted: from 8bit to quoted-printable by robin.gentoo.org id jBQ0EXB0032492 X-Archives-Salt: 8b0a5d50-c31b-442b-bdef-2e0ae171a828 X-Archives-Hash: 4f8e2ade25f3b36f6d5b8b744d7e4a74 On Monday 26 December 2005 08:14, Brian Harring wrote: > On Mon, Dec 26, 2005 at 12:54:04AM +0200, Petteri R=C3=A4ty wrote: > > Currently there are quite a few ebuilds in the tree that execute dodo= c > > or dohtml for files that do not exist. I think it would be nice to ha= ve > > ebuilds die if this is the case. To not break current ebuilds this wo= uld > > only happen with FEATURES=3D"stricter". This is what I currently do i= n my > > bashrc. Obviously when integreted to portage one can use helper > > functions like hasq which are not available in bashrc. > > > > > > if [[ "${FEATURES/stricter}" !=3D "${FEATURES}" ]]; then > > > > _makefail() { > > bin=3D"/usr/lib/portage/bin/${1}" > > shift 1 > > "${bin}" "${@}" || die "${bin} ${@} failed" > > } > > > > dodoc() { _makefail ${FUNCNAME} "${@}"; } > > dohtml() { _makefail ${FUNCNAME} "${@}"; } > > Seems like more of a -dev discussion imo, since they're the ones > affected by it (for us it's just an api change). As a side note, dodoc didn't return non-zero when specified files don't e= xist=20 up until a month or two ago. dohtml was updated yesterday. Hence, up unti= l=20 now the above was not possible. -- Jason Stubbs --=20 gentoo-dev@gentoo.org mailing list