Re: [gentoo-dev] making dodoc and dohtml die when they fail and stricter is on

[Jason Stubbs <jstubbs@gentoo.org>]

On Monday 26 December 2005 08:14, Brian Harring wrote:
> On Mon, Dec 26, 2005 at 12:54:04AM +0200, Petteri Räty wrote:
> > Currently there are quite a few ebuilds in the tree that execute dodoc
> > or dohtml for files that do not exist. I think it would be nice to have
> > ebuilds die if this is the case. To not break current ebuilds this would
> > only happen with FEATURES="stricter". This is what I currently do in my
> > bashrc. Obviously when integreted to portage one can use helper
> > functions like hasq which are not available in bashrc.
> >
> >
> > if [[ "${FEATURES/stricter}" != "${FEATURES}" ]]; then
> >
> > _makefail() {
> > 	bin="/usr/lib/portage/bin/${1}"
> > 	shift 1
> > 	"${bin}" "${@}" || die "${bin} ${@} failed"
> > }
> >
> > dodoc() {	_makefail ${FUNCNAME} "${@}"; }
> > dohtml() {	_makefail ${FUNCNAME} "${@}"; }
>
> Seems like more of a -dev discussion imo, since they're the ones
> affected by it (for us it's just an api change).

As a side note, dodoc didn't return non-zero when specified files don't exist 
up until a month or two ago. dohtml was updated yesterday. Hence, up until 
now the above was not possible.

--
Jason Stubbs

-- 
gentoo-dev@gentoo.org mailing list