[gentoo-dev] FEATURES=test and the internet

[gentoo-dev] FEATURES=test and the internet

[Dan Meltzer]

I've been running my latest install with features=test, makes it
simple to test packages requiring stablizization and all that... at
least partially..

However, I've seen a few packages that fetch stuff during the test
phase from the internet, which seems like a _really_ bad idea to me. 
For 1,  what if I -f while dialed up and then disconnect, and for two,
what happens if the site it's connecting to is down? These can both
effect the outcome of my emerge.

So far, I've seen one of each
libxml2 fetches a DTD, it fetched fine, but if I had not had
internet... it probably would have died, a simple possible fix to this
is to add the dtd to SRC_URI, but this an extra thing to handle for
people without FEATURES="test", and without feature-specific deps
(farily useless overall), there would have to be a USE="test" to take
advantage of this.

The other is net-misc/neon, this one has a down upstream server, and
the build died because of this

Only way I can think of to fix this is to disable the test.


Test policy seems fairly vague in general, maybe this is a good time
to clarify//enforce it?

Opinions? Comments? Flames?

Thats what the mailing list is for!

-- 
gentoo-dev@gentoo.org mailing list

Re: [gentoo-dev] FEATURES=test and the internet

[Ciaran McCreesh]

[-- Attachment #1: Type: text/plain, Size: 763 bytes --]

On Thu, 17 Nov 2005 02:38:13 +0000 Dan Meltzer
<parallelgrapefruit@gmail.com> wrote:
| libxml2 fetches a DTD, it fetched fine, but if I had not had
| internet... it probably would have died, a simple possible fix to this
| is to add the dtd to SRC_URI, but this an extra thing to handle for
| people without FEATURES="test", and without feature-specific deps
| (farily useless overall), there would have to be a USE="test" to take
| advantage of this.

https://bugs.gentoo.org/show_bug.cgi?id=105170

And the general solution to fixing things:

https://bugs.gentoo.org/show_bug.cgi?id=82513

-- 
Ciaran McCreesh : Gentoo Developer (Look! Shiny things!)
Mail            : ciaranm at gentoo.org
Web             : http://dev.gentoo.org/~ciaranm


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

Re: [gentoo-dev] FEATURES=test and the internet

[Mike Frysinger]

On Thu, Nov 17, 2005 at 02:38:13AM +0000, Dan Meltzer wrote:
> However, I've seen a few packages that fetch stuff during the test
> phase from the internet

if you have any packages other than libxml2 that do this, you should
file bug reports about each one
-mike
-- 
gentoo-dev@gentoo.org mailing list

Re: [gentoo-dev] FEATURES=test and the internet

[Alec Joseph Warner]

So who do I have to bribe to get my packages on the bad QA list? :)

On Thu, 17 Nov 2005, Mike Frysinger wrote:

> On Thu, Nov 17, 2005 at 02:38:13AM +0000, Dan Meltzer wrote:
> > However, I've seen a few packages that fetch stuff during the test
> > phase from the internet
>
> if you have any packages other than libxml2 that do this, you should
> file bug reports about each one
> -mike
> --
> gentoo-dev@gentoo.org mailing list
>
-- 
gentoo-dev@gentoo.org mailing list

Re: [gentoo-dev] FEATURES=test and the internet

[Michael Cummings]

Ciaran McCreesh wrote:
> 
> https://bugs.gentoo.org/show_bug.cgi?id=82513
> 
Anyone know why jstubbs closed the bug without comment? I don't see
where it was particualrly resolved.
-- 
gentoo-dev@gentoo.org mailing list

Re: [gentoo-dev] FEATURES=test and the internet

[Jason Stubbs]

On Thursday 17 November 2005 22:17, Michael Cummings wrote:
> Ciaran McCreesh wrote:
> > https://bugs.gentoo.org/show_bug.cgi?id=82513
>
> Anyone know why jstubbs closed the bug without comment? I don't see
> where it was particualrly resolved.

There are several requests on the bug, the majority are now fixed and 
everybody (at least within the portage team) is agreed that FEATURES
should not be added to USE_EXPAND. Essentially, I didn't take the time
to read through all the follow-ups related (and unrelated) to the one
request that wasn't addressed. A comment didn't seem to be required as
it appeared to be one of those bugs that are left open for months after
being fixed. Reopen and adjust the summary to something relevant if
you like.

--
Jason Stubbs
-- 
gentoo-dev@gentoo.org mailing list

Re: [gentoo-dev] FEATURES=test and the internet

[Michael Cummings]

Jason Stubbs wrote:
 > There are several requests on the bug, the majority are now fixed and
> everybody (at least within the portage team) is agreed that FEATURES
> should not be added to USE_EXPAND. Essentially, I didn't take the time
> to read through all the follow-ups related (and unrelated) to the one
> request that wasn't addressed. A comment didn't seem to be required as
> it appeared to be one of those bugs that are left open for months after
> being fixed. Reopen and adjust the summary to something relevant if
> you like.

There's a reason that bugzilla mandates you provide a comment before
closing a bug - even if its to say what you just did.

While the bug may have devolved, the original gist still stands - can we
have a means of having FEATURES="maktest" translated into a use flag
without requiring users to set both? (see my last comment in the bug for
my interest on the matter :) I'm not advocating a full FEATURE explosion
or anything of the like, and maybe this is something that should have
been a USE flag and not a FEATURE to begin with, but its where we're at.

I can of course take this over to bugzilla if you'd prefer :)


~mcummings
-- 
gentoo-dev@gentoo.org mailing list

Re: [gentoo-dev] FEATURES=test and the internet

[Jason Stubbs]

On Friday 18 November 2005 22:20, Michael Cummings wrote:
> Jason Stubbs wrote:
>  > There are several requests on the bug, the majority are now fixed and
> >
> > everybody (at least within the portage team) is agreed that FEATURES
> > should not be added to USE_EXPAND. Essentially, I didn't take the time
> > to read through all the follow-ups related (and unrelated) to the one
> > request that wasn't addressed. A comment didn't seem to be required as
> > it appeared to be one of those bugs that are left open for months after
> > being fixed. Reopen and adjust the summary to something relevant if
> > you like.
>
> There's a reason that bugzilla mandates you provide a comment before
> closing a bug - even if its to say what you just did.

"Resolved - Fixed"?

> While the bug may have devolved, the original gist still stands - can we
> have a means of having FEATURES="maktest" translated into a use flag
> without requiring users to set both? (see my last comment in the bug for
> my interest on the matter :) I'm not advocating a full FEATURE explosion
> or anything of the like, and maybe this is something that should have
> been a USE flag and not a FEATURE to begin with, but its where we're at.

The last discussion that was had ended up with a TDEPEND, but that doesn't
cover the additional SRC_URI requirements. Besides SRC_URI, are there any
other requirements that might sneak in later on?

> I can of course take this over to bugzilla if you'd prefer :)

Nah, let's get it in the open (again) and get it dealt with.

--
Jason Stubbs
-- 
gentoo-dev@gentoo.org mailing list

Re: [gentoo-dev] FEATURES=test and the internet

[Jason Stubbs]

On Saturday 19 November 2005 01:13, Michael Cummings wrote:
> Jason Stubbs wrote:
> > "Resolved - Fixed"?
>
> Hmmm, might have been aq epiphany quirk (wouldn't be the first) - when i
> looked there was no comment indicated.

Nope. I wrote ".". Bugs wrote the above for me. ;)

> > The last discussion that was had ended up with a TDEPEND, but that
> > doesn't cover the additional SRC_URI requirements. Besides SRC_URI, are
> > there any other requirements that might sneak in later on?
>
> and this is the other reason i took it off -dev - so i don't sound like
> an idiot -there's a TPDEPEND now?? That would 100% cover my needs, since
> these are testing depends.

A TDEPEND? Nope, not yet. It's just a possible solution that won't require
overloading USE flags for internal purposes further.

> > Nah, let's get it in the open (again) and get it dealt with.
>
> OK, so i violated that, but now i'm wondering if my needs are already
> covered (hey, could happen) :)

Not just yet...

--
Jason Stubbs
-- 
gentoo-dev@gentoo.org mailing list