Re: [gentoo-dev] Re: [gentoo-portage-dev] allow extra info to be echod on die

[Brian Harring <ferringb@gentoo.org>]

[-- Attachment #1: Type: text/plain, Size: 1033 bytes --]

On Wed, Oct 05, 2005 at 03:04:23PM -0400, Aron Griffis wrote:
> Brian Harring wrote:	[Wed Oct 05 2005, 02:47:09PM EDT]
> >>  diefunc() {
> >>         local funcname="$1" lineno="$2" exitcode="$3"
> >>         shift 3
> >> @@ -289,6 +291,7 @@
> >>         echo "!!! ${*:-(no error message)}" >&2
> >>         echo "!!! If you need support, post the topmost build error, NOT 
> >this status message." >&2
> >>         echo >&2
> >> +	for x in $EBUILD_DEATH_HOOKS; do
> >> +		${x} "$1" "$2" "$3"
> >> +       done
> >>         exit 1
> >>  }
> 
> Is this exactly what went in?  It looks like you're trying to use
> positional params that were shifted earlier.

No, the hooks are called with "$@" actually, plus some checks to 
ensure that
A) the output goes to stderr, which is the norm for die
B) the hooks aren't engaged during depends phase.

if people are after the func/line/exit code being handed to the hook, 
it can be changed, the intention was for this to allow dumping extra 
debug info.
~harring

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]