Re: [gentoo-dev] Re: Player, Stage, Gazebo eBuilds

[Ciaran McCreesh <ciaranm@gentoo.org>]

[-- Attachment #1: Type: text/plain, Size: 1085 bytes --]

On Wed, 31 Aug 2005 21:22:34 +0000 Forrest Voight <voights@gmail.com>
wrote:
| If you want to you can test it. I still have some dependency issues
| with player/stage. This is a standalone program.

Some things to start with:

* LICENSE is incorrect.

* A lot of those dependencies are optional and should be handled via
USE flags.

* If the current src_compile were all that was needed, you could remove
it.

* You probably shouldn't use einstall.

* You should remember to install the README, TODO, AUTHORS, ChangeLog
files using dodoc.

* Your spacing is kind of peculiar. The occasional blank line won't
kill you.

I've not tried actually using the ebuild, these are just syntax things.
Any dependency issues you mention will also need to be fixed.

Anyway, it's better to do this kind of thing through bugzilla rather
than clutter the mailing list up with lots of ebuild revisions.

-- 
Ciaran McCreesh : Gentoo Developer (Vim, Shell tools, Fluxbox, Cron)
Mail            : ciaranm at gentoo.org
Web             : http://dev.gentoo.org/~ciaranm


[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]