* [gentoo-dev] death to underquoted M4 definitions
@ 2005-05-18 7:34 Aaron Walker
2005-05-18 12:00 ` Diego 'Flameeyes' Pettenò
` (2 more replies)
0 siblings, 3 replies; 13+ messages in thread
From: Aaron Walker @ 2005-05-18 7:34 UTC (permalink / raw
To: gentoo-dev
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Fellow devs,
I'd like to propose a new function for eutils.eclass that fixes m4 files so
that aclocal doesn't produce those annoying underquoted definition warnings
when invoked.
fix_underquoted_m4defs() {
local m4
for m4 in $(find ${S} -name '*.m4*' -type f) ; do
[[ ${m4} == *aclocal.m4 || ${m4} == *acinclude.m4 ]] && \
continue
sed -i \
's|^\(.*AC_DEFUN(\)\([^[:punct:]][[:print:]]\+\),\(.*\)$|\1[\2],\3|g' \
${m4}
done
}
ebuilds that install m4's with underquoted defs (there's quite a few) can then
just call this in src_unpack (until fixed upstream of course).
Comments?
- --
"I'm a mean green mother from outer space"
-- Audrey II, The Little Shop of Horrors
Aaron Walker <ka0ttic@gentoo.org>
[ BSD | cron | forensics | shell-tools | commonbox | netmon | vim | web-apps ]
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)
iD8DBQFCiu/vC3poscuANHARAhQ+AJ9lDHZDIkWG/5GRZoZgbo1/HrwrawCg3z1E
5jXrjwzz4gdCX30bshuI1mo=
=TrEG
-----END PGP SIGNATURE-----
--
gentoo-dev@gentoo.org mailing list
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [gentoo-dev] death to underquoted M4 definitions
2005-05-18 7:34 [gentoo-dev] death to underquoted M4 definitions Aaron Walker
@ 2005-05-18 12:00 ` Diego 'Flameeyes' Pettenò
2005-05-18 13:42 ` Aaron Walker
2005-05-18 12:18 ` Daniel
2005-05-18 12:24 ` Mike Frysinger
2 siblings, 1 reply; 13+ messages in thread
From: Diego 'Flameeyes' Pettenò @ 2005-05-18 12:00 UTC (permalink / raw
To: gentoo-dev
[-- Attachment #1: Type: text/plain, Size: 635 bytes --]
On Wednesday 18 May 2005 09:34, Aaron Walker wrote:
> Comments?
Hmm I'm not sure about adding a "band-aid function"... fixing the underquoted
definitions is usually trivial and requires just a little little patch.
Adding a function surely will remove the need for a patch for package, and
this is good, but I'm not sure about the sed expression.
You tried it with bsd sed anyway? :)
So the problem is: the patch will remove the need for all the patches? In this
case, I think I'd love it :)
--
Diego "Flameeyes" Pettenò
Gentoo Developer (Gentoo/FreeBSD, Video, Gentoo/AMD64)
http://dev.gentoo.org/~flameeyes/
[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [gentoo-dev] death to underquoted M4 definitions
2005-05-18 7:34 [gentoo-dev] death to underquoted M4 definitions Aaron Walker
2005-05-18 12:00 ` Diego 'Flameeyes' Pettenò
@ 2005-05-18 12:18 ` Daniel
2005-05-18 12:24 ` Mike Frysinger
2 siblings, 0 replies; 13+ messages in thread
From: Daniel @ 2005-05-18 12:18 UTC (permalink / raw
To: gentoo-dev
[-- Attachment #1: Type: text/plain, Size: 549 bytes --]
On Wed, 18 May 2005 05:34 pm, Aaron Walker wrote:
> Fellow devs,
>
> I'd like to propose a new function for eutils.eclass that fixes m4 files so
> that aclocal doesn't produce those annoying underquoted definition warnings
> when invoked.
>
> fix_underquoted_m4defs() {
>
> Comments?
Sounds great! Good one Aaron.
>
> Aaron Walker <ka0ttic@gentoo.org>
> [ BSD | cron | forensics | shell-tools | commonbox | netmon | vim |
> web-apps ]
--
Daniel Black <dragonheart@gentoo.org>
Gentoo Crypto/PPC/dev-embedded/Forensics/NetMon
[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [gentoo-dev] death to underquoted M4 definitions
2005-05-18 7:34 [gentoo-dev] death to underquoted M4 definitions Aaron Walker
2005-05-18 12:00 ` Diego 'Flameeyes' Pettenò
2005-05-18 12:18 ` Daniel
@ 2005-05-18 12:24 ` Mike Frysinger
2005-05-18 13:39 ` Aaron Walker
2005-05-18 17:16 ` Harald van Dijk
2 siblings, 2 replies; 13+ messages in thread
From: Mike Frysinger @ 2005-05-18 12:24 UTC (permalink / raw
To: gentoo-dev
On Wednesday 18 May 2005 03:34 am, Aaron Walker wrote:
> I'd like to propose a new function for eutils.eclass that fixes m4 files so
> that aclocal doesn't produce those annoying underquoted definition warnings
> when invoked.
i'd have to agree with Diego ... i'd rather see people add patches that change
1 line in .m4 files ... in fact, ive already patched a bunch of the more
common ones, i just didnt rev bump them :p
-mike
--
gentoo-dev@gentoo.org mailing list
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [gentoo-dev] death to underquoted M4 definitions
2005-05-18 12:24 ` Mike Frysinger
@ 2005-05-18 13:39 ` Aaron Walker
2005-05-18 15:11 ` Donnie Berkholz
2005-05-18 17:16 ` Harald van Dijk
1 sibling, 1 reply; 13+ messages in thread
From: Aaron Walker @ 2005-05-18 13:39 UTC (permalink / raw
To: gentoo-dev
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Mike Frysinger wrote:
> On Wednesday 18 May 2005 03:34 am, Aaron Walker wrote:
>
>>I'd like to propose a new function for eutils.eclass that fixes m4 files so
>>that aclocal doesn't produce those annoying underquoted definition warnings
>>when invoked.
>
>
> i'd have to agree with Diego ... i'd rather see people add patches that change
> 1 line in .m4 files ... in fact, ive already patched a bunch of the more
> common ones, i just didnt rev bump them :p
> -mike
Ok that's fine. A function just seemed saner than adding 1 lines patches to
dozens of packages.
- --
Well, I'm disenchanted too. We're all disenchanted.
-- James Thurber
Aaron Walker <ka0ttic@gentoo.org>
[ BSD | cron | forensics | shell-tools | commonbox | netmon | vim | web-apps ]
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)
iD8DBQFCi0WkC3poscuANHARAnoPAJ94jLQr6NDnWlhuLF/99X1Aw4zHNgCghge4
ZS1y9lp9u37MIBjn64fxL6g=
=QeBL
-----END PGP SIGNATURE-----
--
gentoo-dev@gentoo.org mailing list
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [gentoo-dev] death to underquoted M4 definitions
2005-05-18 12:00 ` Diego 'Flameeyes' Pettenò
@ 2005-05-18 13:42 ` Aaron Walker
2005-05-18 13:48 ` Diego 'Flameeyes' Pettenò
2005-05-18 13:52 ` Stephen Bennett
0 siblings, 2 replies; 13+ messages in thread
From: Aaron Walker @ 2005-05-18 13:42 UTC (permalink / raw
To: gentoo-dev
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Diego 'Flameeyes' Pettenò wrote:
> You tried it with bsd sed anyway? :)
sed is still aliased to gsed, no?
- --
One good turn usually gets most of the blanket.
Aaron Walker <ka0ttic@gentoo.org>
[ BSD | cron | forensics | shell-tools | commonbox | netmon | vim | web-apps ]
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)
iD8DBQFCi0ZBC3poscuANHARAnPWAJ99cld19pXKjq5w3ozPxTKhi8OyIACdEyrd
GeqnG/myFViA9JOaRD74uX0=
=QlfG
-----END PGP SIGNATURE-----
--
gentoo-dev@gentoo.org mailing list
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [gentoo-dev] death to underquoted M4 definitions
2005-05-18 13:42 ` Aaron Walker
@ 2005-05-18 13:48 ` Diego 'Flameeyes' Pettenò
2005-05-18 13:52 ` Stephen Bennett
1 sibling, 0 replies; 13+ messages in thread
From: Diego 'Flameeyes' Pettenò @ 2005-05-18 13:48 UTC (permalink / raw
To: gentoo-dev
[-- Attachment #1: Type: text/plain, Size: 305 bytes --]
On Wednesday 18 May 2005 15:42, Aaron Walker wrote:
> sed is still aliased to gsed, no?
Yes but I don't trust sed calls which depends on specific behaviour of gnu
tools.
--
Diego "Flameeyes" Pettenò
Gentoo Developer (Gentoo/FreeBSD, Video, Gentoo/AMD64)
http://dev.gentoo.org/~flameeyes/
[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [gentoo-dev] death to underquoted M4 definitions
2005-05-18 13:42 ` Aaron Walker
2005-05-18 13:48 ` Diego 'Flameeyes' Pettenò
@ 2005-05-18 13:52 ` Stephen Bennett
1 sibling, 0 replies; 13+ messages in thread
From: Stephen Bennett @ 2005-05-18 13:52 UTC (permalink / raw
To: gentoo-dev
On Wed, 2005-05-18 at 09:42 -0400, Aaron Walker wrote:
> sed is still aliased to gsed, no?
Yes, but I want to kill that if possible.
--
gentoo-dev@gentoo.org mailing list
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [gentoo-dev] death to underquoted M4 definitions
2005-05-18 13:39 ` Aaron Walker
@ 2005-05-18 15:11 ` Donnie Berkholz
2005-05-18 16:24 ` Aaron Walker
2005-05-18 16:32 ` Diego 'Flameeyes' Pettenò
0 siblings, 2 replies; 13+ messages in thread
From: Donnie Berkholz @ 2005-05-18 15:11 UTC (permalink / raw
To: gentoo-dev
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Aaron Walker wrote:
> Ok that's fine. A function just seemed saner than adding 1 lines patches to
> dozens of packages.
It may be easier, but upstream would appreciate us sending a patch
instead of just fixing stuff locally.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)
iD8DBQFCi1sIXVaO67S1rtsRAk7yAKCcYrqqV8qwPlVv0tBSiBN0rbFmtQCg3LrB
DhIYcAEuc4Qn1YJsXsTuF5A=
=xgVC
-----END PGP SIGNATURE-----
--
gentoo-dev@gentoo.org mailing list
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [gentoo-dev] death to underquoted M4 definitions
2005-05-18 15:11 ` Donnie Berkholz
@ 2005-05-18 16:24 ` Aaron Walker
2005-05-18 16:32 ` Diego 'Flameeyes' Pettenò
1 sibling, 0 replies; 13+ messages in thread
From: Aaron Walker @ 2005-05-18 16:24 UTC (permalink / raw
To: gentoo-dev
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Donnie Berkholz wrote:
> Aaron Walker wrote:
>
>>>Ok that's fine. A function just seemed saner than adding 1 lines patches to
>>>dozens of packages.
>
>
> It may be easier, but upstream would appreciate us sending a patch
> instead of just fixing stuff locally.
That was never my intention. Notice my original message said "until fixed
upstream". I probably should have made this more clear.
- --
Since we have to speak well of the dead, let's knock them while they're alive.
-- John Sloan
Aaron Walker <ka0ttic@gentoo.org>
[ BSD | cron | forensics | shell-tools | commonbox | netmon | vim | web-apps ]
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)
iD8DBQFCi2wxC3poscuANHARApLiAKDNMtpp5VeYspfzsYNYETq9M85VdwCgsZic
uAIHgSA2hxdjW3tN0Iab26Q=
=Ewsr
-----END PGP SIGNATURE-----
--
gentoo-dev@gentoo.org mailing list
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [gentoo-dev] death to underquoted M4 definitions
2005-05-18 15:11 ` Donnie Berkholz
2005-05-18 16:24 ` Aaron Walker
@ 2005-05-18 16:32 ` Diego 'Flameeyes' Pettenò
1 sibling, 0 replies; 13+ messages in thread
From: Diego 'Flameeyes' Pettenò @ 2005-05-18 16:32 UTC (permalink / raw
To: gentoo-dev
[-- Attachment #1: Type: text/plain, Size: 434 bytes --]
On Wednesday 18 May 2005 17:11, Donnie Berkholz wrote:
> It may be easier, but upstream would appreciate us sending a patch
> instead of just fixing stuff locally.
Not sure about this, we have also some not-so-friendly upstreams sometimes :)
Well anyway I hope all those can be fixed soon, so ...
--
Diego "Flameeyes" Pettenò
Gentoo Developer (Gentoo/FreeBSD, Video, Gentoo/AMD64)
http://dev.gentoo.org/~flameeyes/
[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [gentoo-dev] death to underquoted M4 definitions
2005-05-18 12:24 ` Mike Frysinger
2005-05-18 13:39 ` Aaron Walker
@ 2005-05-18 17:16 ` Harald van Dijk
2005-05-18 18:50 ` Mike Frysinger
1 sibling, 1 reply; 13+ messages in thread
From: Harald van Dijk @ 2005-05-18 17:16 UTC (permalink / raw
To: gentoo-dev
Mike Frysinger wrote:
> i'd have to agree with Diego ... i'd rather see people add patches that change
> 1 line in .m4 files ... in fact, ive already patched a bunch of the more
> common ones, i just didnt rev bump them :p
> -mike
The patch for xdelta (and possibly others) uses the full location as the
filename. This causes sandbox errors, because patch tries to modify the
m4 file in / (but, only if it exists and isn't patched already), instead
of the one in the working directory. Want a bug?
--
gentoo-dev@gentoo.org mailing list
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [gentoo-dev] death to underquoted M4 definitions
2005-05-18 17:16 ` Harald van Dijk
@ 2005-05-18 18:50 ` Mike Frysinger
0 siblings, 0 replies; 13+ messages in thread
From: Mike Frysinger @ 2005-05-18 18:50 UTC (permalink / raw
To: gentoo-dev
On Wednesday 18 May 2005 01:16 pm, Harald van Dijk wrote:
> Mike Frysinger wrote:
> > i'd have to agree with Diego ... i'd rather see people add patches that
> > change 1 line in .m4 files ... in fact, ive already patched a bunch of
> > the more common ones, i just didnt rev bump them :p
> > -mike
>
> The patch for xdelta (and possibly others) uses the full location as the
> filename. This causes sandbox errors, because patch tries to modify the
> m4 file in / (but, only if it exists and isn't patched already), instead
> of the one in the working directory. Want a bug?
i think xdelta is the only one i screwed up, i'll fix it
-mike
--
gentoo-dev@gentoo.org mailing list
^ permalink raw reply [flat|nested] 13+ messages in thread
end of thread, other threads:[~2005-05-18 18:50 UTC | newest]
Thread overview: 13+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-05-18 7:34 [gentoo-dev] death to underquoted M4 definitions Aaron Walker
2005-05-18 12:00 ` Diego 'Flameeyes' Pettenò
2005-05-18 13:42 ` Aaron Walker
2005-05-18 13:48 ` Diego 'Flameeyes' Pettenò
2005-05-18 13:52 ` Stephen Bennett
2005-05-18 12:18 ` Daniel
2005-05-18 12:24 ` Mike Frysinger
2005-05-18 13:39 ` Aaron Walker
2005-05-18 15:11 ` Donnie Berkholz
2005-05-18 16:24 ` Aaron Walker
2005-05-18 16:32 ` Diego 'Flameeyes' Pettenò
2005-05-18 17:16 ` Harald van Dijk
2005-05-18 18:50 ` Mike Frysinger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox