From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.gentoo.org (smtp.gentoo.org [134.68.220.30]) by robin.gentoo.org (8.13.3/8.13.3) with ESMTP id j2G3IEsb026459 for ; Wed, 16 Mar 2005 03:18:14 GMT Received: from adsl-67-39-48-196.dsl.milwwi.ameritech.net ([67.39.48.196] helo=freedom.wit.com) by smtp.gentoo.org with esmtpa (Exim 4.43) id 1DBP2t-0004iA-Un for gentoo-dev@robin.gentoo.org; Wed, 16 Mar 2005 03:18:09 +0000 Date: Tue, 15 Mar 2005 21:17:26 -0600 From: Brian Harring To: gentoo-dev@robin.gentoo.org Subject: Re: [gentoo-dev] CONFIG_PROTECT and ROOT!='/' Message-ID: <20050316031726.GA23157@freedom.wit.com> References: <4235BFB0.70907@rle.ru> <4236004E.1010007@gentoo.org> <1110860664.11759.3.camel@matrix.brianandsara.net> <20050315065600.GA5908@ols-dell.iic.hokudai.ac.jp> <20050315161413.GA17344@lion.gg3.net> <20050315230543.GB7990@lion.gg3.net> Precedence: bulk List-Post: , , List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@gentoo.org Reply-To: gentoo-dev@gentoo.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20050315230543.GB7990@lion.gg3.net> User-Agent: Mutt/1.5.6i X-Archives-Salt: 2f28a9e9-ac72-4041-b935-cb818663bf94 X-Archives-Hash: 150ba72e1068c6b7dbb058c87e6cd98c On Wed, Mar 16, 2005 at 08:05:43AM +0900, Georgi Georgiev wrote: > maillog: 15/03/2005-12:01:47(-0600): Brian Jackson types > > On 10:14:14 am 2005-03-15 Georgi Georgiev wrote: > > > maillog: 15/03/2005-08:26:49(-0600): Brian Jackson types > > > > I have a bug filed for that too, but it's probably going to be a > > > > while before it's fixed. From what I've been told, it's not > > > > trivial to fix it because some of the config stuff isn't very > > > > well abstracted. > > > > > > It isn't? Are we talking about the same thing? After all, the > > > locations are just variables, that only need to be prefixed with > > > something. Could we get some input from whoever told you this? > > > > make.conf is easy. The profile isn't as easy. /etc/portage isn't easy > > at all. That's the basics. You'd have to ask the portage guys for more > > in depth info. > > I was hoping to get a response from them here. Portage guys, you there? http://www.gentoo.org/cgi-bin/viewcvs.cgi/portage/pym/config.py?root=gentoo-src ^^^^ config class, cleaned up a bit from what stable has. At the moment, my focus on the bugger is the following- A) integration of env whitelist tracking, preferably in a an attached instance (the need for this is partially bound to covering filter-env's ass). B) either reorganize the beast so env stuff is accessible via an attribute, or create a container class that the config gets assigned into C) bind all tree instances to the config. Why? Kill off portage.db global usage entirely, and try and encapsulate data into one common, passable instance D) shift virtual loading, setcpv, setinst, load_infodir, etc, all out of config and to a proper class. So... why tack that stuff in now, when the class itself needs a major enema? :) Basically it comes down to a focus (at this point) in trying to improve the existing code/abstractions in use, rather then tacking more features/codepaths in. Anyone interested can take a crack at the request above, it's just not high on my peronsal (likely our) list of priorities, since the existing code is spaghetti like. Note that integration of env whitelisting *is* adding a new feature in. It's kind of required to keep things sane for the env handling though (mainly, a few very crazy var settings are *very* hard to properly filter). That and it can't be done without refactoring the config class anyways (which is intended)... ~harring -- gentoo-dev@gentoo.org mailing list