maillog: 07/12/2004-19:59:05(+0000): Ferris McCormick types > On Mon, 6 Dec 2004, Donnie Berkholz wrote: > > > Hey everyone, > > > > If anybody has good reasons why -r4 shouldn't be unleashed upon the > > unsuspecting ~arch users, respond to this (on-list please) before 0000 > > UTC Wednesday. Why then? Well, my finals will be over, so I'll have time > > to deal with the expected deluge of reports. > > > > Sparc tests fine under the following conditions: > > 1. ebuild taken from cvs at 13:06 (GMT) > 2. USE flags thus: > =========================== > lacewing root # PKGDIR=${PD} emerge -pkv xorg-x11 > > These are the packages that I would merge, in order: > > Calculating dependencies ...done! > [binary R ] x11-base/xorg-x11-6.8.0-r4 (-3dfx) (-3dnow) +bitmap-fonts > -cjk -debug +dlloader -dmx -doc -font-server +hardened +insecure-drivers > -ipv6 -minimal (-mmx) +nls +opengl +pam -sdk (-sse) -static > +truetype-fonts +type1-fonts (-uclibc) -xprint +xv [1] > =========================== > > 3. Because of the +dlloader, necessarily the patches from Bug 61063 were > applied. > 4. This version of X is hardened. > 5. The (deprecated) keyboard driver is still required. kbd shifts keys as > it always has. > > 6. NOTE: The two 'is_kernel' tests produce error messages, but (for me, > at any rate) ebuild operation is correct anyway. I have not > investigated further, but as I recall, the messages were: > [: wrong number of arguments (for the check kernel-2.2.x) > Command '*' not understood This is what I had in my overlay while testing the ebuild yesterday. The linux-info.eclass kernel_is() should only return an exit code so its output should not be looked at. I.e. those "[" and "$(" are not needed. --- /usr/portage/x11-base/xorg-x11/xorg-x11-6.8.0-r4.ebuild 2004-12-07 13:23:15.000000000 +0900 +++ ./xorg-x11-6.8.0-r4.ebuild 2004-12-07 17:59:24.000000000 +0900 @@ -670,7 +674,7 @@ fi if ( [ -e "${ROOT}/usr/src/linux" ] \ - && [ ! $(kernel_is "2" "2") ] ) \ + && ! ( kernel_is "2" "2" ) ) \ || [ "$(uname -r | cut -d. -f1,2)" != "2.2" ]; then echo "#define HasLinuxInput YES" >> ${HOSTCONF} fi @@ -794,7 +798,7 @@ echo "#define ModuleAsCmd CcCmd -c -x assembler -fno-pie -fno-PIE" >> ${HOSTCONF} fi if ( [ -e "${ROOT}/usr/src/linux" ] \ - && !( $(kernel_is "2" "6") ) ) \ + && !( kernel_is "2" "6" ) ) \ || [ "$(uname -r | cut -d. -f1,2)" != "2.6" ]; then einfo "Building for kernels less than 2.6 requires special treatment" echo "#define UseDeprecatedKeyboardDriver YES" >> ${HOSTCONF} -- \ Georgi Georgiev \ Don't lose Your head To gain a minute You \ / chutz@gg3.net / need your head Your brains are in it. -- / \ +81(90)6266-1163 \ Burma Shave \