From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29096 invoked from network); 12 Nov 2004 15:25:16 +0000 Received: from smtp.gentoo.org (156.56.111.197) by lists.gentoo.org with AES256-SHA encrypted SMTP; 12 Nov 2004 15:25:16 +0000 Received: from lists.gentoo.org ([156.56.111.196] helo=parrot.gentoo.org) by smtp.gentoo.org with esmtp (Exim 4.41) id 1CSdIa-00034t-Bp for arch-gentoo-dev@lists.gentoo.org; Fri, 12 Nov 2004 15:25:16 +0000 Received: (qmail 3451 invoked by uid 89); 12 Nov 2004 15:25:08 +0000 Mailing-List: contact gentoo-dev-help@gentoo.org; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@gentoo.org Received: (qmail 21194 invoked from network); 12 Nov 2004 15:25:08 +0000 Date: Fri, 12 Nov 2004 10:22:02 -0500 X-OfflineIMAP-x1010183630-70696d656e7473656e64-494e424f582e4f7574626f78: 1100273104-0957773693872-v4.0.7 From: Aron Griffis To: gentoo-dev@lists.gentoo.org Message-ID: <20041112152202.GA452@time.flatmonk.org> Mail-Followup-To: gentoo-dev@lists.gentoo.org References: <20041111234522.40d8f48d@snowdrop.home> <419451F6.1010202@gentoo.org> <20041112070757.GA21178@tiger.gg3.net> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="r5Pyd7+fXNt84Ff3" Content-Disposition: inline In-Reply-To: <20041112070757.GA21178@tiger.gg3.net> User-Agent: Mutt/1.5.6i Subject: Re: [gentoo-dev] einfo / ewarn banners and die messages X-Archives-Salt: 21e4d684-5586-4ade-9aad-f828639d6820 X-Archives-Hash: ed2d7f9be187be56c0c391024aed9b05 --r5Pyd7+fXNt84Ff3 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Georgi Georgiev wrote: [Fri Nov 12 2004, 02:07:58AM EST] > Shouldn't do*, in*, new* die on a failure? I've flip-flopped on this one. Previously I said that all dies should be in the ebuild itself. I even fixed a lot of ebuilds to call die after said commands. But I think that's a losing battle. Nowadays I agree that it would be easiest and best if econf, emake, do*, new*, etc. would die on failure. The simple reason is that there is no situation in which one of these commands should fail normally in the course of an ebuild. The problem is that it isn't always possible. Many of the commands are implemented as scripts in /usr/lib/portage/bin instead of functions so they can be used on the RHS of xargs. One possibility would be to implement both: (1) functions in ebuild.sh that would die automatically and (2) scripts in /usr/lib/portage/bin that would operate on the RHS of xargs. You'd lose the ability to die automatically in the latter case, but hopefully it's rare enough that it wouldn't be a big deal. Regards, Aron -- Aron Griffis Gentoo Linux Developer --r5Pyd7+fXNt84Ff3 Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.9.10 (GNU/Linux) iD8DBQFBlNUaJrHF4yAQTrARAvzgAKCTGCyLOrd7PHfZ6n/yGs34wuFOvgCdElwi ZbtKizk5QDDyOT5gSF9PCDY= =OZNU -----END PGP SIGNATURE----- --r5Pyd7+fXNt84Ff3--