Re: [gentoo-dev] einfo / ewarn banners and die messages

[Aron Griffis <agriffis@gentoo.org>]

[-- Attachment #1: Type: text/plain, Size: 1083 bytes --]

Georgi Georgiev wrote:	[Fri Nov 12 2004, 02:07:58AM EST]
> Shouldn't do*, in*, new* die on a failure?

I've flip-flopped on this one.  Previously I said that all dies should
be in the ebuild itself.  I even fixed a lot of ebuilds to call die
after said commands.  But I think that's a losing battle.  Nowadays I
agree that it would be easiest and best if econf, emake, do*, new*,
etc. would die on failure.  The simple reason is that there is no
situation in which one of these commands should fail normally in the
course of an ebuild.

The problem is that it isn't always possible.  Many of the commands
are implemented as scripts in /usr/lib/portage/bin instead of
functions so they can be used on the RHS of xargs.

One possibility would be to implement both: (1) functions in ebuild.sh
that would die automatically and (2) scripts in /usr/lib/portage/bin
that would operate on the RHS of xargs.  You'd lose the ability to die
automatically in the latter case, but hopefully it's rare enough that
it wouldn't be a big deal.

Regards,
Aron

--
Aron Griffis
Gentoo Linux Developer


[-- Attachment #2: Type: application/pgp-signature, Size: 190 bytes --]