From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24353 invoked from network); 11 Aug 2004 02:51:53 +0000 Received: from smtp.gentoo.org (156.56.111.197) by lists.gentoo.org with AES256-SHA encrypted SMTP; 11 Aug 2004 02:51:53 +0000 Received: from lists.gentoo.org ([156.56.111.196] helo=parrot.gentoo.org) by smtp.gentoo.org with esmtp (Exim 4.34) id 1BujDV-0006CQ-7x for arch-gentoo-dev@lists.gentoo.org; Wed, 11 Aug 2004 02:51:53 +0000 Received: (qmail 13445 invoked by uid 89); 11 Aug 2004 02:51:52 +0000 Mailing-List: contact gentoo-dev-help@gentoo.org; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@gentoo.org Received: (qmail 16419 invoked from network); 11 Aug 2004 02:51:52 +0000 X-Originating-IP: [205.241.48.33] From: "Donnie Berkholz" To: gentoo-dev@lists.gentoo.org In-Reply-To: <20040810120404.GB1912@hydra.joerghoh.de> Date: Tue, 10 Aug 2004 22:51:51 -0400 Message-ID: <20040811.IRf.44677300@groupware.gentoo.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 8bit Content-Disposition: inline X-Mailer: AngleMail for eGroupWare (http://www.egroupware.org) v 0.9.99.026 Subject: Re: [gentoo-dev] RFC: extension of etc-update X-Archives-Salt: f447aa2e-f1e7-4f67-b53d-e6db4d265d62 X-Archives-Hash: 08895ac79868e98b08cff3ad268671b5 Joerg Hoh (joerg@devone.org) wrote: > > On Tue, Aug 10, 2004 at 01:52:30PM +0200, Radoslaw Stachowiak wrote: > > > > it doesnt in proper way, because dispatch-conf does not store md5sums, > > but uses /var/db/pkg data for its comparision. But using it (db) after > > installation results in md5sum lost (only md5 sums of NEW version of > > files are stored). > > > > So there are two ways to do it: > > 1. store sums regardless of portage, and compare it after installation. > > 2. maybe, instead of md5sum, simple comparision if mtime < ctime than > > update is allowed would be fine? > > > > please comment about 2) because it would be trivial to implement it in > > dispatch-conf. > > ctime vs mtime would be acceptable; if it is combined with the > trivial-merge-approach, it's probably enough for most of the mentioned > issues. This still appears to have this problem, unless I missed it: What if the default is exactly what a user wants in one version, then the default changes in the next version? You assume an unmodified config file means the user doesn't care what's in it. But in this scenario, the file's MD5 would be unchanged from the initial snapshot because the file is distributed as the user desires -- yet an update wrongly overwrites this with a change that causes broken or unwanted results. There should be at least an option to NOT do the MD5 checking you propose. Thanks, Donnie -- Donnie Berkholz Gentoo Linux -- gentoo-dev@gentoo.org mailing list