From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28596 invoked by uid 1002); 20 Nov 2003 20:23:12 -0000 Mailing-List: contact gentoo-dev-help@gentoo.org; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@gentoo.org Received: (qmail 6789 invoked from network); 20 Nov 2003 20:23:11 -0000 Date: Thu, 20 Nov 2003 15:23:10 -0500 From: Aron Griffis To: gentoo-dev@gentoo.org Message-ID: <20031120202310.GA17707@time> Mail-Followup-To: gentoo-dev@gentoo.org References: <20031119174820.271e16f6.spider@gentoo.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="ReaqsoxgOBHFXBhH" Content-Disposition: inline In-Reply-To: <20031119174820.271e16f6.spider@gentoo.org> User-Agent: Mutt/1.5.4i Subject: Re: [gentoo-dev] My first ebuild: GNU Hello X-Archives-Salt: 94c3268a-c26e-46cb-9eb8-6fc4b5113ba5 X-Archives-Hash: 391c62a3a8ae5b65861dc649debd3a1e --ReaqsoxgOBHFXBhH Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Spider wrote: [Wed Nov 19 2003, 11:48:20AM EST] > Don't emake and econf both fail if they fail, making || die "" =20 > unnecessary and even impossible? It's really poor practice to depend on this. I argued against this change and was ignored. Here are some reasons: - Calling die from econf/emake defeats the function and line number reporting that are part of die. - Developers have to keep track of which ebuild.sh functions call die and which ones don't. It's really better to leave the error handling in the ebuild in all cases so that the practice is simply to call die in all situations where it is appropriate. Aron --=20 Aron Griffis Gentoo Linux Developer (alpha / ia64 / ruby / vim) Key fingerprint =3D E3B6 8734 C2D6 B5E5 AE76 FB3A 26B1 C5E3 2010 4EB0 --ReaqsoxgOBHFXBhH Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.3 (GNU/Linux) iD8DBQE/vSKuJrHF4yAQTrARAiA4AKCpOAKXfBVvhD2y8t5plhkUp5GskQCcDCpw 7RQnSXuUjCf/bYCbCwC4TM4= =sXwW -----END PGP SIGNATURE----- --ReaqsoxgOBHFXBhH--