From: Aron Griffis <agriffis@gentoo.org>
To: gentoo-dev@gentoo.org
Subject: Re: [gentoo-dev] My first ebuild: GNU Hello
Date: Thu, 20 Nov 2003 15:23:10 -0500 [thread overview]
Message-ID: <20031120202310.GA17707@time> (raw)
In-Reply-To: <20031119174820.271e16f6.spider@gentoo.org>
[-- Attachment #1: Type: text/plain, Size: 822 bytes --]
Spider wrote: [Wed Nov 19 2003, 11:48:20AM EST]
> Don't emake and econf both fail if they fail, making || die ""
> unnecessary and even impossible?
It's really poor practice to depend on this. I argued against this
change and was ignored. Here are some reasons:
- Calling die from econf/emake defeats the function and line number
reporting that are part of die.
- Developers have to keep track of which ebuild.sh functions call
die and which ones don't. It's really better to leave the error
handling in the ebuild in all cases so that the practice is simply
to call die in all situations where it is appropriate.
Aron
--
Aron Griffis
Gentoo Linux Developer (alpha / ia64 / ruby / vim)
Key fingerprint = E3B6 8734 C2D6 B5E5 AE76 FB3A 26B1 C5E3 2010 4EB0
[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]
next prev parent reply other threads:[~2003-11-20 20:23 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-11-19 12:39 [gentoo-dev] My first ebuild: GNU Hello Marco Maggesi
2003-11-19 16:48 ` Spider
2003-11-19 17:44 ` [gentoo-dev] " Marco Maggesi
2003-11-20 20:23 ` Aron Griffis [this message]
2003-11-20 20:40 ` [gentoo-dev] " Grant Goodyear
2003-11-23 23:52 ` Aron Griffis
2003-11-20 22:27 ` Spider
2003-11-19 17:06 ` James Harlow
2003-11-19 18:39 ` [gentoo-dev] " Marco Maggesi
2003-11-19 18:58 ` James Harlow
2003-11-19 20:20 ` Matthew Kennedy
2003-11-19 17:46 ` [gentoo-dev] " Matthew Kennedy
2003-11-19 18:41 ` [gentoo-dev] " Marco Maggesi
2003-11-19 20:43 ` [gentoo-dev] " Eldad Zack
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20031120202310.GA17707@time \
--to=agriffis@gentoo.org \
--cc=gentoo-dev@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox