[gentoo-dev] Time to Stop and Clean

[gentoo-dev] Time to Stop and Clean

[Spider]

[-- Attachment #1: Type: text/plain, Size: 332 bytes --]

Okay folks,
   Could all ye developers take the time to go through your packages and
check that there are -no- references to ${D} ${S} , ${W} in pkg_* 
statements?

 thankyou.
//Spider

-- 
begin  .signature
This is a .signature virus! Please copy me into your .signature!
See Microsoft KB Article Q265230 for more information.
end

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]

Re: [gentoo-dev] Time to Stop and Clean

[Aron Griffis]

[-- Attachment #1: Type: text/plain, Size: 4569 bytes --]

Spider wrote:	[Sun Nov 09 2003, 07:02:38PM EST]
> Could all ye developers take the time to go through your packages and
> check that there are -no- references to ${D} ${S} , ${W} in pkg_* 
> statements?

All the offenders (assuming this is actually an offense):

$ find . -name \*.ebuild | xargs perl -0777 -ne 'for $p (/pkg_[^{]*\{.*?\n\}/gs) { next unless $p =~ /\$\{?[DSW]\b/; print "$ARGV\n"; last }'

./dev-tex/listings/listings-1.1.ebuild
./games-server/halflife-server/halflife-server-3.1.1.0.ebuild
./app-admin/rackview/rackview-0.04-r1.ebuild
./gnome-base/gconf/gconf-2.4.0.1.ebuild
./gnome-base/gconf/gconf-2.2.1.ebuild
./gnome-base/gconf/gconf-2.2.0.ebuild
./net-firewall/giptables/giptables-1.1.ebuild
./sys-devel/automake/automake-1.7.5-r2.ebuild
./sys-devel/automake/automake-1.7.7.ebuild
./sys-devel/automake/automake-1.7.2.ebuild
./sys-devel/automake/automake-1.6.1-r6.ebuild
./sys-devel/automake/automake-1.6.3.ebuild
./sys-devel/automake/automake-1.7.8.ebuild
./dev-db/phppgadmin/phppgadmin-3.1.ebuild
./net-dns/bind/bind-9.2.3.ebuild
./net-dns/bind/bind-9.2.2-r3.ebuild
./net-dns/bind/bind-9.2.2.ebuild
./net-dns/bind/bind-9.2.2-r2.ebuild
./net-dns/bind/bind-9.2.2_rc1-r2.ebuild
./net-dns/bind/bind-9.2.2-r1.ebuild
./net-www/resin-ee/resin-ee-2.1.9.ebuild
./net-www/resin/resin-2.1.9.ebuild
./media-libs/plotutils/plotutils-2.4.1-r2.ebuild
./media-libs/pdflib/pdflib-4.0.1-r3.ebuild
./media-libs/pdflib/pdflib-4.0.3-r1.ebuild
./games-roguelike/angband/angband-3.0.3.ebuild
./sys-apps/baselayout/baselayout-1.8.6.8-r1.ebuild
./sys-apps/baselayout/baselayout-1.8.6.11.ebuild
./sys-apps/baselayout/baselayout-1.8.6.10-r1.ebuild
./sys-libs/glibc/glibc-2.3.2-r6.ebuild
./sys-libs/glibc/glibc-2.3.2-r1.ebuild
./sys-libs/glibc/glibc-2.3.1-r4.ebuild
./sys-libs/glibc/glibc-2.2.5-r8.ebuild
./sys-libs/glibc/glibc-2.3.2-r8.ebuild
./sys-libs/glibc/glibc-2.3.2-r7.ebuild
./sys-libs/glibc/glibc-2.3.2-r2.ebuild
./app-emulation/spim/spim-6.5.ebuild
./app-emulation/vmware-workstation/vmware-workstation-4.0.2.5592-r1.ebuild
./app-emulation/vmware-workstation/vmware-workstation-3.2.1.2242-r1.ebuild
./app-emulation/vmware-workstation/vmware-workstation-4.0.5.6030.ebuild
./net-mail/courier/courier-0.44.0.ebuild
./net-mail/courier/courier-0.42.2.ebuild
./net-mail/courier/courier-0.43.2.ebuild
./net-misc/nut/nut-1.4.0.ebuild
./net-misc/nut/nut-1.0.0.ebuild
./net-misc/nut/nut-1.2.1.ebuild
./net-misc/nut/nut-1.3.6.ebuild
./net-misc/nut/nut-1.2.2.ebuild
./net-misc/nut/nut-1.2.1-r1.ebuild
./net-misc/nut/nut-1.5.1.ebuild
./net-misc/knutclient/knutclient-0.7.1.ebuild
./net-misc/knutclient/knutclient-0.6.0.ebuild
./net-misc/omniORB/omniORB-305.ebuild
./net-news/leafnode/leafnode-1.9.42.ebuild
./net-news/leafnode/leafnode-2.0.0_alpha20030621.ebuild
./x11-wm/flwm/flwm-1.00-r4.ebuild
./x11-wm/flwm/flwm-1.00-r3.ebuild
./x11-wm/flwm/flwm-1.00-r2.ebuild
./dev-java/jmf/jmf-2.1.1e.ebuild
./dev-java/bluej/bluej-1.3.0.ebuild
./dev-java/bluej/bluej-1.2.2.ebuild
./dev-java/jdbc3-oracle/jdbc3-oracle-9.2.0.1.ebuild
./dev-java/jdbc3-oracle/jdbc3-oracle-9.2.0.3.ebuild
./dev-java/makeme/makeme-0.02-r2.ebuild
./dev-java/jdbc2-oracle/jdbc2-oracle-9.0.1.4.ebuild
./dev-java/jdbc2-oracle/jdbc2-oracle-9.2.0.1.ebuild
./dev-java/jdbc2-oracle/jdbc2-oracle-8.1.7.ebuild
./dev-java/jdbc2-oracle/jdbc2-oracle-9.2.0.3.ebuild
./dev-java/jdbc2-oracle/jdbc2-oracle-9.0.1.ebuild
./dev-java/xerces/xerces-2.3.0-r1.ebuild
./dev-java/xerces/xerces-2.5.0.ebuild
./dev-lang/nhc98/nhc98-1.16.ebuild
./dev-util/glade/glade-2.0.0-r1.ebuild
./media-fonts/urw-fonts/urw-fonts-2.0-r1.ebuild
./media-fonts/urw-fonts/urw-fonts-2.0.ebuild
./media-sound/alsa-patch-bay/alsa-patch-bay-0.5.1-r1.ebuild
./media-sound/alsa-patch-bay/alsa-patch-bay-0.5.2.ebuild
./app-doc/qt-docs/qt-docs-3.0.4.1.ebuild
./net-analyzer/nagios-core/nagios-core-1.1-r3.ebuild
./net-analyzer/nagios-core/nagios-core-1.1-r4.ebuild
./net-analyzer/nagios-plugins/nagios-plugins-1.3.0.ebuild
./net-analyzer/nagios-plugins/nagios-plugins-1.3.0_beta3-r1.ebuild
./net-analyzer/nagios-plugins/nagios-plugins-1.3.0-r2.ebuild
./net-analyzer/nagios-plugins/nagios-plugins-1.3.0_beta2.ebuild
./net-analyzer/nagios-plugins/nagios-plugins-1.3.0_beta2-r1.ebuild
./net-analyzer/nagios-plugins/nagios-plugins-1.3.0-r1.ebuild
./net-analyzer/nagios-plugins/nagios-plugins-1.3.0_beta3.ebuild
./games-action/heroes/heroes-0.21.ebuild

-- 
Aron Griffis
Gentoo Linux Developer
Key fingerprint = E3B6 8734 C2D6 B5E5 AE76  FB3A 26B1 C5E3 2010 4EB0


[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]

Re: [gentoo-dev] Time to Stop and Clean

[Spider]

[-- Attachment #1: Type: text/plain, Size: 965 bytes --]

begin  quote
On Wed, 12 Nov 2003 18:46:13 -0500
Aron Griffis <agriffis@gentoo.org> wrote:

> Spider wrote:	[Sun Nov 09 2003, 07:02:38PM EST]
> > Could all ye developers take the time to go through your packages
> > and
> > check that there are -no- references to ${D} ${S} , ${W} in pkg_* 
> > statements?
> 
> All the offenders (assuming this is actually an offense):


a -perfect- example is this :
./app-emulation/spim/spim-6.5.ebuild 

pkg_postinst() {
	cd ${S}
	cp Makefile.comp Makefile	
	make test || die "Test failed"
}


in a package situation, ${S} isnt there because we never built it, so
this will fail the first cd, then it will fail cp (I have no idea where
it will be when it does this actually)  after this the || die segment
will always happen becuase make probably won't find a Makefile.


//Spider


-- 
begin  .signature
This is a .signature virus! Please copy me into your .signature!
See Microsoft KB Article Q265230 for more information.
end

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]

Re: [gentoo-dev] Time to Stop and Clean

[Spider]

[-- Attachment #1: Type: text/plain, Size: 1250 bytes --]

begin  quote
On Wed, 12 Nov 2003 18:46:13 -0500
Aron Griffis <agriffis@gentoo.org> wrote:

> Spider wrote:	[Sun Nov 09 2003, 07:02:38PM EST]
> > Could all ye developers take the time to go through your packages
> > and
> > check that there are -no- references to ${D} ${S} , ${W} in pkg_* 
> > statements?
> 
> All the offenders (assuming this is actually an offense):


More interesting examples:
./net-news/leafnode/leafnode-2.0.0_alpha20030621.ebuild 
pkg_postinst() {
	mkdir -p
/var/spool/news/{leaf.node,failed.postings,interesting.groups,out.going}
	mkdir -p
/var/spool/news/message.id/{0,1,2,3,4,5,6,7,8,9}{0,1,2,3,4,5,6,7,8,9}{0
,1,2,3,4,5,6,7,8,9}
	chown -R news:news /var/spool/news


# All those should use ${ROOT}/  first.

	cat ${S}/README_FIRST | while read line ;
# This won't -ever- happen because there is no ${S}


Can we make portage change the ${S} variable when inside pkg_ 
statements, so things actually break when people work with this, rather
than have obscure misuse of stuff in the tree?  or even better. more
tests to repoman that bails on things like this.


//Spider







-- 
begin  .signature
This is a .signature virus! Please copy me into your .signature!
See Microsoft KB Article Q265230 for more information.
end

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]

[gentoo-dev] Re: Time to Stop and Clean

[sf]

Spider wrote:
...
> Can we make portage change the ${S} variable when inside pkg_ 
> statements, so things actually break when people work with this, rather
> than have obscure misuse of stuff in the tree?  or even better. more

One way I can think of is calling pkg_* after "set -u" (and probably 
"set -e", too). This would break many packages and maybe even portage 
itself but in the long run should make portage and ebuilds safer.

Regards,
	Stephan



--
gentoo-dev@gentoo.org mailing list

Re: [gentoo-dev] Time to Stop and Clean

[Stroller]

On Nov 13, 2003, at 3:28 pm, Spider wrote:

> begin  quote
> On Wed, 12 Nov 2003 18:46:13 -0500
> Aron Griffis <agriffis@gentoo.org> wrote:
>
>> Spider wrote:	[Sun Nov 09 2003, 07:02:38PM EST]
>>> Could all ye developers take the time to go through your packages
>>> and
>>> check that there are -no- references to ${D} ${S} , ${W} in pkg_*
>>> statements?
>>
>> All the offenders (assuming this is actually an offense):
>
>
> More interesting examples:
> ./net-news/leafnode/leafnode-2.0.0_alpha20030621.ebuild
> pkg_postinst() {
> 	mkdir -p
> /var/spool/news/ 
> {leaf.node,failed.postings,interesting.groups,out.going}
> 	mkdir -p
> /var/spool/news/message.id/{0,1,2,3,4,5,6,7,8,9}{0,1,2,3,4,5,6,7,8,9}{0
> ,1,2,3,4,5,6,7,8,9}
> 	chown -R news:news /var/spool/news

I think the Leafnode2 eBuild is broken, anyway. It seems to install  
into /var/lib/spool/news/
See <http://bugs.gentoo.org/show_bug.cgi?id=25713> - I have attached a  
copy of the ebuild which seems to work here.

Stroller.


--
gentoo-dev@gentoo.org mailing list

Re: [gentoo-dev] Time to Stop and Clean

[Spider]

[-- Attachment #1: Type: text/plain, Size: 2244 bytes --]

begin  quote
On Sat, 15 Nov 2003 13:16:13 +0000
Stroller <root@stellar.eclipse.co.uk> wrote:

> 
> On Nov 13, 2003, at 3:28 pm, Spider wrote:
> 
> > begin  quote
> > On Wed, 12 Nov 2003 18:46:13 -0500
> > Aron Griffis <agriffis@gentoo.org> wrote:
> >
> >> Spider wrote:	[Sun Nov 09 2003, 07:02:38PM EST]
> >>> Could all ye developers take the time to go through your packages
> >>> and
> >>> check that there are -no- references to ${D} ${S} , ${W} in pkg_*
> >>> statements?
> >>
> >> All the offenders (assuming this is actually an offense):
> >
> >
> > More interesting examples:
> > ./net-news/leafnode/leafnode-2.0.0_alpha20030621.ebuild
> > pkg_postinst() {
> > 	mkdir -p
> > /var/spool/news/ 
> > {leaf.node,failed.postings,interesting.groups,out.going}
> > 	mkdir -p
> > /var/spool/news/message.id/{0,1,2,3,4,5,6,7,8,9}{0,1,2,3,4,5,6,7,8,
> > 9}{0
> > ,1,2,3,4,5,6,7,8,9}
> > 	chown -R news:news /var/spool/news
> 
> I think the Leafnode2 eBuild is broken, anyway. It seems to install  
> into /var/lib/spool/news/
> See <http://bugs.gentoo.org/show_bug.cgi?id=25713> - I have attached a
>  
> copy of the ebuild which seems to work here.
> 

Proposed version still has theese lines :

	cat ${S}/README_FIRST | while read line ;
	do
		einfo $line
	done


And when you build packages, you never unpack the source, therefore ${S}
will not reference to any place where README_FIRST is.

do zcat ${ROOT}/usr/share/doc/${P}/README_FIRST.gz  instead.


And your "mkdir -p" lines are also broken, as theese will fail if I
expose ROOT for installation to some system that isn't / (also for
package installation)

theese should refer to ${ROOT}/var/spool ....

(check baselayout for a good example of things to do or not do)

Anyhow, is there a good reason why you create theese in the pkg_ part
instead of in src_install after you have done the main installation?  
I'd consider this broken behaviour, as any special case isn't documented
in the build either.


try "dodir
${D}/var/spool/news/message.id/{0,1,2,3,4,5,6,7,8,9}{0,1,2,3,4,5,6,7,8,
9}{0,1,2,3,4,5,6,7,8,9}"  instead




//Spider






-- 
begin  .signature
This is a .signature virus! Please copy me into your .signature!
See Microsoft KB Article Q265230 for more information.
end

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]

Re: [gentoo-dev] Time to Stop and Clean

[Aron Griffis]

[-- Attachment #1: Type: text/plain, Size: 206 bytes --]

Spider,

Repoman should be updated to check for these problems, shouldn't it?

Aron

-- 
Aron Griffis
Gentoo Linux Developer
Key fingerprint = E3B6 8734 C2D6 B5E5 AE76  FB3A 26B1 C5E3 2010 4EB0


[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]

Re: [gentoo-dev] Time to Stop and Clean

[Spider]

[-- Attachment #1: Type: text/plain, Size: 638 bytes --]

begin  quote
On Sat, 15 Nov 2003 10:46:59 -0500
Aron Griffis <agriffis@gentoo.org> wrote:

> Spider,
> 
> Repoman should be updated to check for these problems, shouldn't it?


Yes, it very much should, but i'm not up to implemneting the checks,
which is why I'm right now moaning and whining on -dev instead
of fixing stuffs :)

Actually, I generally prefer to educate than to silently fix things,  
means less work in the future. (Hopefully people actually read this
thread)




//Spider


-- 
begin  .signature
This is a .signature virus! Please copy me into your .signature!
See Microsoft KB Article Q265230 for more information.
end

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]

Re: [gentoo-dev] Time to Stop and Clean

[Stroller]

On Nov 15, 2003, at 3:17 pm, Spider wrote:
>>
>> I think the Leafnode2 eBuild is broken, anyway. It seems to install
>> into /var/lib/spool/news/
>> See <http://bugs.gentoo.org/show_bug.cgi?id=25713> - I have attached a
>>
>> copy of the ebuild which seems to work here.
>>
>
> Proposed version still has theese lines :
>
> 	cat ${S}/README_FIRST | while read line ;
> 	do
> 		einfo $line
> 	done

Sorry - I wasn't considering this aspect of the ebuild. All I have done 
- some months ago - is changed 2 lines of the ebuild to correct the 
/var path.

> And when you build packages, you never unpack the source, therefore 
> ${S}
> will not reference to any place where README_FIRST is.
>
> do zcat ${ROOT}/usr/share/doc/${P}/README_FIRST.gz  instead.
>
>
> And your "mkdir -p" lines are also broken...
> Anyhow, is there a good reason why you create theese in the pkg_ part
> instead of in src_install after you have done the main installation?

None of these are my implementations. I'm ashamed to admit that I don't 
really know enough Bash scripting to write ebuilds. I'd just like to 
see a good ebuild for this package in the portage tree & modified those 
2 lines of the present one.

Stroller.


--
gentoo-dev@gentoo.org mailing list