From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25550 invoked by uid 1002); 15 Nov 2003 15:17:30 -0000 Mailing-List: contact gentoo-dev-help@gentoo.org; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@gentoo.org Received: (qmail 14551 invoked from network); 15 Nov 2003 15:17:30 -0000 Date: Sat, 15 Nov 2003 16:17:26 +0100 From: Spider To: gentoo-dev@gentoo.org Message-Id: <20031115161726.10f6a957.spider@gentoo.org> In-Reply-To: References: <20031110010238.682c8609.spider@gentoo.org> <20031112234613.GG30382@time> <20031113162836.3a8ab80e.spider@gentoo.org> Organization: Gentoo.org X-Mailer: Sylpheed version 0.9.5-gtk2-20030906 (GTK+ 2.2.4; i686-pc-linux-gnu) Mime-Version: 1.0 Content-Type: multipart/signed; protocol="application/pgp-signature"; micalg="pgp-sha1"; boundary="PiBh)GRJ=.t(30K4" Subject: Re: [gentoo-dev] Time to Stop and Clean X-Archives-Salt: 143b05ac-6f26-455e-8374-22752e841e6f X-Archives-Hash: db16f0278c245c6031a3dffe60942da5 --PiBh)GRJ=.t(30K4 Content-Type: text/plain; charset=US-ASCII Content-Disposition: inline Content-Transfer-Encoding: 7bit begin quote On Sat, 15 Nov 2003 13:16:13 +0000 Stroller wrote: > > On Nov 13, 2003, at 3:28 pm, Spider wrote: > > > begin quote > > On Wed, 12 Nov 2003 18:46:13 -0500 > > Aron Griffis wrote: > > > >> Spider wrote: [Sun Nov 09 2003, 07:02:38PM EST] > >>> Could all ye developers take the time to go through your packages > >>> and > >>> check that there are -no- references to ${D} ${S} , ${W} in pkg_* > >>> statements? > >> > >> All the offenders (assuming this is actually an offense): > > > > > > More interesting examples: > > ./net-news/leafnode/leafnode-2.0.0_alpha20030621.ebuild > > pkg_postinst() { > > mkdir -p > > /var/spool/news/ > > {leaf.node,failed.postings,interesting.groups,out.going} > > mkdir -p > > /var/spool/news/message.id/{0,1,2,3,4,5,6,7,8,9}{0,1,2,3,4,5,6,7,8, > > 9}{0 > > ,1,2,3,4,5,6,7,8,9} > > chown -R news:news /var/spool/news > > I think the Leafnode2 eBuild is broken, anyway. It seems to install > into /var/lib/spool/news/ > See - I have attached a > > copy of the ebuild which seems to work here. > Proposed version still has theese lines : cat ${S}/README_FIRST | while read line ; do einfo $line done And when you build packages, you never unpack the source, therefore ${S} will not reference to any place where README_FIRST is. do zcat ${ROOT}/usr/share/doc/${P}/README_FIRST.gz instead. And your "mkdir -p" lines are also broken, as theese will fail if I expose ROOT for installation to some system that isn't / (also for package installation) theese should refer to ${ROOT}/var/spool .... (check baselayout for a good example of things to do or not do) Anyhow, is there a good reason why you create theese in the pkg_ part instead of in src_install after you have done the main installation? I'd consider this broken behaviour, as any special case isn't documented in the build either. try "dodir ${D}/var/spool/news/message.id/{0,1,2,3,4,5,6,7,8,9}{0,1,2,3,4,5,6,7,8, 9}{0,1,2,3,4,5,6,7,8,9}" instead //Spider -- begin .signature This is a .signature virus! Please copy me into your .signature! See Microsoft KB Article Q265230 for more information. end --PiBh)GRJ=.t(30K4 Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.3 (GNU/Linux) iD8DBQE/tkOIZS9CZTi033kRAjNBAKCDWg47Cv4NyEzppRonrqXlKxOlswCdHPUe 3gKWg/pUuntunVUdFrhFU0g= =U1hT -----END PGP SIGNATURE----- --PiBh)GRJ=.t(30K4--