From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9463 invoked by uid 1002); 13 Nov 2003 15:28:40 -0000 Mailing-List: contact gentoo-dev-help@gentoo.org; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@gentoo.org Received: (qmail 29866 invoked from network); 13 Nov 2003 15:28:40 -0000 Date: Thu, 13 Nov 2003 16:28:36 +0100 From: Spider To: gentoo-dev@gentoo.org Message-Id: <20031113162836.3a8ab80e.spider@gentoo.org> In-Reply-To: <20031112234613.GG30382@time> References: <20031110010238.682c8609.spider@gentoo.org> <20031112234613.GG30382@time> Organization: Gentoo.org X-Mailer: Sylpheed version 0.9.5-gtk2-20030906 (GTK+ 2.2.4; i686-pc-linux-gnu) Mime-Version: 1.0 Content-Type: multipart/signed; protocol="application/pgp-signature"; micalg="pgp-sha1"; boundary="=.MaAjgQL69:2DJ." Subject: Re: [gentoo-dev] Time to Stop and Clean X-Archives-Salt: b81c43c8-82dc-4602-883b-eddd8ee869fc X-Archives-Hash: 09fea966ad1c2d674990b3efeaabfe0c --=.MaAjgQL69:2DJ. Content-Type: text/plain; charset=US-ASCII Content-Disposition: inline Content-Transfer-Encoding: 7bit begin quote On Wed, 12 Nov 2003 18:46:13 -0500 Aron Griffis wrote: > Spider wrote: [Sun Nov 09 2003, 07:02:38PM EST] > > Could all ye developers take the time to go through your packages > > and > > check that there are -no- references to ${D} ${S} , ${W} in pkg_* > > statements? > > All the offenders (assuming this is actually an offense): More interesting examples: ./net-news/leafnode/leafnode-2.0.0_alpha20030621.ebuild pkg_postinst() { mkdir -p /var/spool/news/{leaf.node,failed.postings,interesting.groups,out.going} mkdir -p /var/spool/news/message.id/{0,1,2,3,4,5,6,7,8,9}{0,1,2,3,4,5,6,7,8,9}{0 ,1,2,3,4,5,6,7,8,9} chown -R news:news /var/spool/news # All those should use ${ROOT}/ first. cat ${S}/README_FIRST | while read line ; # This won't -ever- happen because there is no ${S} Can we make portage change the ${S} variable when inside pkg_ statements, so things actually break when people work with this, rather than have obscure misuse of stuff in the tree? or even better. more tests to repoman that bails on things like this. //Spider -- begin .signature This is a .signature virus! Please copy me into your .signature! See Microsoft KB Article Q265230 for more information. end --=.MaAjgQL69:2DJ. Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.3 (GNU/Linux) iD8DBQE/s6MmZS9CZTi033kRAqOfAKCU/2rHe4TWcv/O8DNNAYVXM83RYACgifdQ Vop0N8a0zRZp/Guzvc4JukM= =R2FT -----END PGP SIGNATURE----- --=.MaAjgQL69:2DJ.--