Re: [gentoo-dev] Time to Stop and Clean

[Spider <spider@gentoo.org>]

[-- Attachment #1: Type: text/plain, Size: 1250 bytes --]

begin  quote
On Wed, 12 Nov 2003 18:46:13 -0500
Aron Griffis <agriffis@gentoo.org> wrote:

> Spider wrote:	[Sun Nov 09 2003, 07:02:38PM EST]
> > Could all ye developers take the time to go through your packages
> > and
> > check that there are -no- references to ${D} ${S} , ${W} in pkg_* 
> > statements?
> 
> All the offenders (assuming this is actually an offense):


More interesting examples:
./net-news/leafnode/leafnode-2.0.0_alpha20030621.ebuild 
pkg_postinst() {
	mkdir -p
/var/spool/news/{leaf.node,failed.postings,interesting.groups,out.going}
	mkdir -p
/var/spool/news/message.id/{0,1,2,3,4,5,6,7,8,9}{0,1,2,3,4,5,6,7,8,9}{0
,1,2,3,4,5,6,7,8,9}
	chown -R news:news /var/spool/news


# All those should use ${ROOT}/  first.

	cat ${S}/README_FIRST | while read line ;
# This won't -ever- happen because there is no ${S}


Can we make portage change the ${S} variable when inside pkg_ 
statements, so things actually break when people work with this, rather
than have obscure misuse of stuff in the tree?  or even better. more
tests to repoman that bails on things like this.


//Spider







-- 
begin  .signature
This is a .signature virus! Please copy me into your .signature!
See Microsoft KB Article Q265230 for more information.
end

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]