Re: [gentoo-dev] Time to Stop and Clean

[Spider <spider@gentoo.org>]

[-- Attachment #1: Type: text/plain, Size: 965 bytes --]

begin  quote
On Wed, 12 Nov 2003 18:46:13 -0500
Aron Griffis <agriffis@gentoo.org> wrote:

> Spider wrote:	[Sun Nov 09 2003, 07:02:38PM EST]
> > Could all ye developers take the time to go through your packages
> > and
> > check that there are -no- references to ${D} ${S} , ${W} in pkg_* 
> > statements?
> 
> All the offenders (assuming this is actually an offense):


a -perfect- example is this :
./app-emulation/spim/spim-6.5.ebuild 

pkg_postinst() {
	cd ${S}
	cp Makefile.comp Makefile	
	make test || die "Test failed"
}


in a package situation, ${S} isnt there because we never built it, so
this will fail the first cd, then it will fail cp (I have no idea where
it will be when it does this actually)  after this the || die segment
will always happen becuase make probably won't find a Makefile.


//Spider


-- 
begin  .signature
This is a .signature virus! Please copy me into your .signature!
See Microsoft KB Article Q265230 for more information.
end

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]