[gentoo-dev] Re: [gentoo-user] Multiple distdirs patch

[gentoo-dev] Re: [gentoo-user] Multiple distdirs patch

[Robin H. Johnson]

[-- Attachment #1: Type: text/plain, Size: 2031 bytes --]

On Thu, Aug 14, 2003 at 12:11:20AM -0500, Kurt V. Hindenburg wrote:
> Just a quick note : If you want to have mutlitple directories in your 
> distfiles search, try my patch.   There are still a number of things that 
> don't work.  Make sure you have the original portage.py as backup.
> http://www.cherrynebula.net/projects/gentoo/gentoo.html
> Feedback is welcomed.

Nice progress on this Kurt. Your patch seems to work here for me, with the
version of portage you meant it for.

Reviewing the latest patch, I see this chunk:
@@ -1399,9 +1506,11 @@
            return 0
        myfile=basedir+"/"+x
        if not os.path.exists(myfile):
-           if strict:
-               print "!!! File does not exist:",myfile
-               return 0
+#KVH
+# What is this suppose to do???  Error : strict variable not found
+#          if strict:
+#              print "!!! File does not exist:",myfile
+#              return 0
            continue
        mymd5=perform_md5(myfile)
        if mymd5 != mydigests[x][0]:


'strict' relates to FEATURES='strict'.

Once you fix that up to so that strict behaves properly, as well as changing this:
+   for d in settings["DISTDIRS"].split(" "):
into:
+   for d in settings["DISTDIRS"].split(":"):

So that it splits on the proper UNIX path seperator as we originally discussed,
I'd be happy to take this patch up to carpaski. You asked who has spaces in
their paths, well, OSX for definate, and if you use samba to provide home
directories for users, spaces turn up there, and in many other places. I use
them wherever they have proper use (instead of cheating with _)

One other thing, to make life easier, could you possible please keep it up to
date with the latest masked portage? (2.0.49_pre17 as I write this).

-- 
Robin Hugh Johnson
E-Mail     : robbat2@orbis-terrarum.net
Home Page  : http://www.orbis-terrarum.net/?l=people.robbat2
ICQ#       : 30269588 or 41961639
GnuPG FP   : 11AC BA4F 4778 E3F6 E4ED  F38E B27B 944E 3488 4E85

[-- Attachment #2: Type: application/pgp-signature, Size: 232 bytes --]