[gentoo-dev] X Support for ufed (patch)

[gentoo-dev] X Support for ufed (patch)

[Ned Ludd]

[-- Attachment #1: Type: text/plain, Size: 336 bytes --]


This patch extends the functionality of ufed (version 0.33/ CVS revision
1.15) to allow us to take advantage of Xdialog when it's installed. The
option can also be overridden using a --no-x option.

Please review and consider for inclusion in the next release of ufed.

--
Ned Ludd <solar@gentoo.org>
Gentoo Linux Developer (Hardened)

[-- Attachment #2: ufed-0.33.diff --]
[-- Type: text/plain, Size: 1602 bytes --]

--- ufed.orig	2003-08-03 17:04:40.000000000 -0400
+++ ufed	2003-08-03 17:13:48.000000000 -0400
@@ -13,7 +13,7 @@
 
 # version number format is x.yy
 # if y<10, you NEED the trailing zero!
-my $version = '0.33';
+my $version = '0.34';
 
 my @make_defaults_flags;
 my @use_defaults_flags;
@@ -29,6 +29,20 @@
 
 my $PortageBase = '/usr/portage';
 
+my $DIALOG = 'dialog';
+
+if (($ENV{'DISPLAY'} ne "") && ($ARGV[0] ne "--no-x")) {
+   if (-x '/usr/bin/Xdialog') {
+      print "Detected Xdialog binary and DISPLAY environment variable. Switching to X-based dialog.\n";
+      print "To prevent this action, unset DISPLAY or pass --no-x to this program.\n";
+      $DIALOG = '/usr/bin/Xdialog';
+   } else {
+      print "Detected DISPLAY environment variable but Xdialog does not appear to be installed.\n";
+      print "If you would like X support you can emerge x11-misc/xdialog. using default dialog now.\n";
+      sleep 2;
+   }
+} 
+
 sub get_flag_from_file
 {
 
@@ -284,7 +298,7 @@
       $items .= '"' . %use_desc_flags->{$flag} . '" ';
    }
 
-   $rc = system('DIALOG_ESC="" dialog 2>'
+   $rc = system('DIALOG_ESC="" '.$DIALOG.' 2>'
                . $tempfile
                . ' --separate-output '
                . '--no-shadow --backtitle "Gentoo Linux USE flags editor '
@@ -449,7 +463,7 @@
 );
    close(FILE);
 
-   system('dialog --exit-label Back --no-shadow --title "What are USE flags?" '
+   system($DIALOG .' --exit-label Back --no-shadow --title "What are USE flags?" '
           . '--backtitle "Gentoo Linux USE flags editor '
           . $version
           . ' - Help" '


[-- Attachment #3: Type: text/plain, Size: 37 bytes --]

--
gentoo-dev@gentoo.org mailing list

[gentoo-dev] Re: X Support for ufed (patch)

[Fred Van Andel]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On August 3, 2003 02:42 pm, you wrote:
> This patch extends the functionality of ufed (version 0.33/ CVS
> revision 1.15) to allow us to take advantage of Xdialog when it's
> installed. The option can also be overridden using a --no-x
> option.
>
> Please review and consider for inclusion in the next release of
> ufed.

Thanks for the patch, I will be included it in the next  version.
It needs a few tweaks to get the look right so it may be a few
days.

- --
Fred Van Andel
fava@gentoo.org
GPG KeyID: 76526AD599455482
GPG fingerprint: 64E4 4BAB 9C99 D565 3E3C F5D0 7652 6AD5 9945 5482
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.2 (GNU/Linux)

iD8DBQE/Lcx0dlJq1ZlFVIIRAvXvAKDw5DSmGoOo5GrNzUrhMlCHq44JPwCZARA+
D7kZrZKGNIfg2dGv7ka1+jY=
=lYjn
-----END PGP SIGNATURE-----


--
gentoo-dev@gentoo.org mailing list