From: George Shapovalov <george@gentoo.org>
To: gentoo-dev@gentoo.org
Subject: Re: [gentoo-dev] Some 'proper coding' notes for ebuilds
Date: Sun, 3 Aug 2003 13:27:25 -0700 [thread overview]
Message-ID: <200308031327.26379.george@gentoo.org> (raw)
In-Reply-To: <200308031953.03414.stuart@gentoo.org>
Well, looks like there is no one around who remembers this thing, so I guess
I'll chime in:
This (tabbed indentation) is indeed a policy. The resuidual indications of
that can be found if you run lintool on some ebuild - it will complain about
spaces before or after the line, tabs are ok (and are supposed to be used for
indentation). While not really used nowadays, lintool is still a usefull
tool, albeit unmaintained :(. Repoman still does not have long-promised
ebuild integrity checks (not all of them at least), therefore I would still
recommend running lintool on new submissions and such (you just have to learn
its (few) misreported features).
There has been a discussion of this issue, I believe over a year ago already.
It has been decided that this indeed is a serious issue, worth being brought
into the policy (main reason I beleive was to settle the never-ending
debates). everybody agreed that it should be either all spaces or all tabs (I
hope nobody would want it otherwise nowadays?)
Upon weighting arguments thrown by bioth groups we have settled on all tabs.
IIRC the deciding reason was that with tabs everyone is free to use their own
level of indentation, while with spaces you are pretty much stuck with what
particular developer used. Therefore we would have to enforce that particular
aspect as well. Oh, should I mention that I am on a tabbed side ;)?
And on this account:
>Because, in any non-trivial piece of code, indents can end up being a mixture
>of tabs and spaces, rather than just tabs. When this happens, and you use a
This is against a policy and is strictly forbidden. All ebuilds in the tree
should only use tabs!
>different tab size to the author, the indented code suddenly becomes a tad
>unreadable.
Above makes this a non-issue, and as I described in the beginning we do have
that enforceent and we put it in place upon discussing alternatives and on
purpose.
George
On Sunday 03 August 2003 11:53, Stuart Herbert wrote:
> Sorry, but your arguments aren't convincing me yet that
>
> a) This belongs in the coding standards at all, and
> b) That tabs are the way to do this
>
> I guess I'm just a cantankerous old bugger, as we say over here ;-)
--
gentoo-dev@gentoo.org mailing list
next prev parent reply other threads:[~2003-08-03 20:27 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-08-03 2:29 [gentoo-dev] Some 'proper coding' notes for ebuilds Mike Frysinger
2003-08-03 2:34 ` Mike Frysinger
2003-08-03 2:38 ` Mike Frysinger
2003-08-03 2:50 ` Kumba
2003-08-03 3:04 ` Mike Frysinger
2003-08-03 15:23 ` Martin Schlemmer
2003-08-03 18:44 ` Mike Frysinger
2003-08-03 15:10 ` Mamoru KOMACHI
2003-08-03 15:40 ` Paul de Vrieze
2003-08-03 16:23 ` Mamoru KOMACHI
2003-08-03 16:27 ` Georgi Georgiev
2003-08-03 17:04 ` Mamoru KOMACHI
2003-08-03 15:30 ` Martin Schlemmer
2003-08-11 13:45 ` Patrick Kursawe
2003-08-11 14:58 ` Mike Frysinger
2003-08-03 5:31 ` Jason A. Mobarak
2003-08-03 4:56 ` Mike Frysinger
2003-08-03 6:11 ` Luke-Jr
2003-08-03 14:55 ` Stuart Herbert
2003-08-03 15:18 ` Martin Schlemmer
2003-08-03 18:07 ` Stuart Herbert
2003-08-03 18:48 ` Mike Frysinger
2003-08-03 18:53 ` Stuart Herbert
2003-08-03 20:27 ` George Shapovalov [this message]
2003-08-03 20:34 ` Stuart Herbert
2003-08-03 22:15 ` George Shapovalov
2003-08-03 22:56 ` Don Seiler
2003-08-08 15:21 ` Anthony de Boer
2003-08-08 15:33 ` Marius Mauch
2003-08-08 18:25 ` George Shapovalov
2003-08-08 19:16 ` Douglas Russell
2003-08-08 20:12 ` George Shapovalov
2003-08-08 23:01 ` Mike Frysinger
2003-08-10 2:58 ` George Shapovalov
2003-08-03 22:19 ` Aron Griffis
[not found] ` <20030803223541.05d10e90.spider@gentoo.org>
2003-08-03 20:43 ` Stuart Herbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200308031327.26379.george@gentoo.org \
--to=george@gentoo.org \
--cc=gentoo-dev@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox