Re: [gentoo-dev] common ebuild mistakes

[Aron Griffis <agriffis@gentoo.org>]

Martin, Stephen wrote:	[Fri May 23 2003, 03:15:33PM EDT]
> I've a couple of questions about this.  Last night I emerged mplayer and 
> noticed that aalib didn't get installed even though I had it in USE. 
> Obviously, fixing this is a trivial change to the RDEPEND section of the 
> ebuild (aalib is autodetected by mplayer and so no change to $myconf is 
> necessary).  

Two comments here:

1. It should be in both DEPEND and RDEPEND, since aalib is required at
   both compile-time and run-time.

2. Changing $myconf is necessary.  The presence of aalib on the system
   should not determine whether mplayer uses aalib.  That should be
   determined by the USE flag.  In other words, mplayer should not use
   aalib when USE=-aalib, even if aalib exists on the system.

Portage provides a couple nice shortcuts to make #2 easier.  Those are
"use_enable" and "use_with".  For example (from vim.eclass)

   myconf="--with-features=huge \
   	--enable-cscope \
   	--enable-multibyte"
   myconf="${myconf} `use_enable gpm`"
   myconf="${myconf} `use_enable perl perlinterp`"
   myconf="${myconf} `use_enable python pythoninterp`"
   myconf="${myconf} `use_enable ruby rubyinterp`"

> What's the best way to handle small changes like this? 
> Should I just file a bug and state what needs to be done, or should I 
> file a bug and attach a diff?  Is there a rule of thumb for how large a 
> change has to be in order to warrant a diff or ebuild?

If you always attach a diff, then there's no room for misinterpretation
of your instructions.  I'd suggest always attaching a diff except for a
pure version bump.

Aron

--
gentoo-dev@gentoo.org mailing list