public inbox for gentoo-dev@lists.gentoo.org
 help / color / mirror / Atom feed
From: Fernand Albarracin <fernand8@wanadoo.fr>
To: gentoo-dev@gentoo.org
Subject: [gentoo-dev] ebuild inconsistencies (was: Community driven meta distribution or only distribution)
Date: Wed, 30 Apr 2003 01:54:37 +0200	[thread overview]
Message-ID: <20030429235437.GA8993@spirou.test-domain> (raw)

Hi,

On Tue 29 Apr 2003 at 15:31:54 -0400, Grant Goodyear wrote:

> A good "reference" ebuild can be found by "man 5 ebuild".

Just checked it, and have few remarks.

Here is a part of the supplied sample ebuild :

	src_compile() {
	    econf || die "could not configure"
	    emake || die "emake failed"
	}

An here is the revelant documentation :

	...
	*Note:  There  is  no need to use '|| die' because
	econf checks for you

	...
	*Note:  Be  sure  to  use  '||  die' constructs to
	ensure emake success

1. The example should be updated.

	src_compile() {
	    econf
	    emake || die "emake failed"
	}

2. It might be a good idea to change emake so that it works just like
econf and einstall. What do you think ? Goal: get a simpler, more
consistent API.

Also right now econf is implemented as a function, and emake as a
program. Is there a good reason for this ? Sure, it does not really
matter from an ebuild writter point of view, it's more a "spring
cleanup" kind of suggestion.

Ok, enough for today :)

Fernand

--
gentoo-dev@gentoo.org mailing list


                 reply	other threads:[~2003-04-29 23:48 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030429235437.GA8993@spirou.test-domain \
    --to=fernand8@wanadoo.fr \
    --cc=gentoo-dev@gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox