[gentoo-dev] DOSEmu ebuild

[gentoo-dev] DOSEmu ebuild

[Per Wigren]

I just looked at the DOSEmu ebuild and saw that it contains LOTS of 
"errors"... (although it does work at the moment(:

> DESCRIPTION="DOSEmu 1.1.3 (Developer)"
Hmm.. What kind of description is that? :) Something like "DOS Emulator" would 
be better..

> src_compile() {
>	chmod +x $S/base-configure
chmod +x base-configure should be enough since we are already in ${S} ..

>### mitshm will bork ./base-configure entirely, so we disable it here
>        myflags="--enable-mitshm=yes"

Hmm.. That doesn't look like disabling it to me, but I want it anyway, so... 
:)

>src_install () {
> ./install_systemwide -fd /usr/portage/distfiles/dosemu-freedos-bin.tgz -r 
/var/tmp/portage/${PF}/image

Should be
./install_systemwide -fd ${DISTDIR}/dosemu-freedos-bin.tgz -r ${D}

> rm -rf ${D}opt/dosemu/man
missing /

// Wigren

Re: [gentoo-dev] DOSEmu ebuild

[Ryan Phillips]

[-- Attachment #1: Type: text/plain, Size: 1110 bytes --]

On Tue, 28 May 2002 07:18:37 +0200
"Per Wigren" <wigren@home.se> wrote:

> I just looked at the DOSEmu ebuild and saw that it contains LOTS of 
> "errors"... (although it does work at the moment(:
> 
> > DESCRIPTION="DOSEmu 1.1.3 (Developer)"
> Hmm.. What kind of description is that? :) Something like "DOS Emulator" would 
> be better..
> 
> > src_compile() {
> >	chmod +x $S/base-configure
> chmod +x base-configure should be enough since we are already in ${S} ..
> 
> >### mitshm will bork ./base-configure entirely, so we disable it here
> >        myflags="--enable-mitshm=yes"
> 
> Hmm.. That doesn't look like disabling it to me, but I want it anyway, so... 
> :)
> 
> >src_install () {
> > ./install_systemwide -fd /usr/portage/distfiles/dosemu-freedos-bin.tgz -r 
> /var/tmp/portage/${PF}/image
> 
> Should be
> ./install_systemwide -fd ${DISTDIR}/dosemu-freedos-bin.tgz -r ${D}
> 
> > rm -rf ${D}opt/dosemu/man
> missing /
> 
> // Wigren

I agree with the changes proposed, but the more proper way *I think* is to contact the
maintainer of the ebuild first, and propose the changes to them.

-ryan

[-- Attachment #2: Type: application/pgp-signature, Size: 481 bytes --]

Re: [gentoo-dev] DOSEmu ebuild

[George Shapovalov]

I would suggest even better way - submitting this to bugs.gentoo.org opening a 
new bug. This way it will get fixed even if original author/maintainer is out 
of reach.

George


On Tuesday 28 May 2002 01:26, Ryan Phillips wrote:
> On Tue, 28 May 2002 07:18:37 +0200
>
> "Per Wigren" <wigren@home.se> wrote:
> > I just looked at the DOSEmu ebuild and saw that it contains LOTS of
> >
> > "errors"... (although it does work at the moment(:
> > > DESCRIPTION="DOSEmu 1.1.3 (Developer)"
> >
> > Hmm.. What kind of description is that? :) Something like "DOS Emulator"
> > would be better..
> >
> > > src_compile() {
> > >	chmod +x $S/base-configure
> >
> > chmod +x base-configure should be enough since we are already in ${S} ..
> >
> > >### mitshm will bork ./base-configure entirely, so we disable it here
> > >        myflags="--enable-mitshm=yes"
> >
> > Hmm.. That doesn't look like disabling it to me, but I want it anyway,
> > so...
> >
> > :)
> > :
> > >src_install () {
> > > ./install_systemwide -fd /usr/portage/distfiles/dosemu-freedos-bin.tgz
> > > -r
> >
> > /var/tmp/portage/${PF}/image
> >
> > Should be
> > ./install_systemwide -fd ${DISTDIR}/dosemu-freedos-bin.tgz -r ${D}
> >
> > > rm -rf ${D}opt/dosemu/man
> >
> > missing /
> >
> > // Wigren
>
> I agree with the changes proposed, but the more proper way *I think* is to
> contact the maintainer of the ebuild first, and propose the changes to
> them.
>
> -ryan

Re: [gentoo-dev] DOSEmu ebuild

[Per Wigren]

Good ideas! Exactly what I would have done if I had have my morning coffee... 
:))
BTW, was that the correct use of have/had? ;)

// Wigren


Tuesday 28 May 2002 10.54 skrev George Shapovalov:
> I would suggest even better way - submitting this to bugs.gentoo.org
> opening a new bug. This way it will get fixed even if original
> author/maintainer is out of reach.
>
> George
>
> On Tuesday 28 May 2002 01:26, Ryan Phillips wrote:
> > On Tue, 28 May 2002 07:18:37 +0200
> >
> > "Per Wigren" <wigren@home.se> wrote:
> > > I just looked at the DOSEmu ebuild and saw that it contains LOTS of
> > >
> > > "errors"... (although it does work at the moment(:
> > > > DESCRIPTION="DOSEmu 1.1.3 (Developer)"
> > >
> > > Hmm.. What kind of description is that? :) Something like "DOS
> > > Emulator" would be better..
> > >
> > > > src_compile() {
> > > >	chmod +x $S/base-configure
> > >
> > > chmod +x base-configure should be enough since we are already in ${S}
> > > ..
> > >
> > > >### mitshm will bork ./base-configure entirely, so we disable it here
> > > >        myflags="--enable-mitshm=yes"
> > >
> > > Hmm.. That doesn't look like disabling it to me, but I want it anyway,
> > > so...
> > >
> > > :)
> > > :
> > > >src_install () {
> > > > ./install_systemwide -fd
> > > > /usr/portage/distfiles/dosemu-freedos-bin.tgz -r
> > >
> > > /var/tmp/portage/${PF}/image
> > >
> > > Should be
> > > ./install_systemwide -fd ${DISTDIR}/dosemu-freedos-bin.tgz -r ${D}
> > >
> > > > rm -rf ${D}opt/dosemu/man
> > >
> > > missing /
> > >
> > > // Wigren
> >
> > I agree with the changes proposed, but the more proper way *I think* is
> > to contact the maintainer of the ebuild first, and propose the changes to
> > them.
> >
> > -ryan
>
> _______________________________________________
> gentoo-dev mailing list
> gentoo-dev@gentoo.org
> http://lists.gentoo.org/mailman/listinfo/gentoo-dev