From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ryan.shaw@stanfordalumni.org>
X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-14) on finch.gentoo.org
X-Spam-Level: 
X-Spam-Status: No, score=-1.1 required=5.0 tests=DMARC_NONE,MAILING_LIST_MULTI,
	NICE_REPLY_A autolearn=unavailable autolearn_force=no version=4.0.0
Received: from smtp.giga.ocn.ne.jp (giga.ocn.ne.jp [211.129.14.85])
	by chiba.3jane.net (Postfix) with ESMTP id 907ACABD51
	for <gentoo-dev@gentoo.org>; Fri, 24 May 2002 02:35:03 -0500 (CDT)
Received: from momo (p8113-adsah09hon-acca.tokyo.ocn.ne.jp [218.224.7.113])
	by smtp.giga.ocn.ne.jp (Postfix) with SMTP id 18E06527F3
	for <gentoo-dev@gentoo.org>; Fri, 24 May 2002 16:35:02 +0900 (JST)
Date: Fri, 24 May 2002 16:29:53 +0900
From: Ryan Shaw <ryan.shaw@stanfordalumni.org>
To: gentoo-dev@gentoo.org
Subject: Re: [gentoo-dev] Using default src_compile() in ebuilds
Message-Id: <20020524162953.59e9915c.ryan.shaw@stanfordalumni.org>
In-Reply-To: <87y9ea58s3.fsf@tea.thpoon.com>
References: <87y9ea58s3.fsf@tea.thpoon.com>
X-Mailer: Sylpheed version 0.7.6claws (GTK+ 1.2.10; i586-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: gentoo-dev-admin@gentoo.org
Errors-To: gentoo-dev-admin@gentoo.org
X-BeenThere: gentoo-dev@gentoo.org
X-Mailman-Version: 2.0.6
Precedence: bulk
Reply-To: gentoo-dev@gentoo.org
List-Help: <mailto:gentoo-dev-request@gentoo.org?subject=help>
List-Post: <mailto:gentoo-dev@gentoo.org>
List-Subscribe: <http://lists.gentoo.org/mailman/listinfo/gentoo-dev>,
	<mailto:gentoo-dev-request@gentoo.org?subject=subscribe>
List-Id: Gentoo Linux developer list <gentoo-dev.gentoo.org>
List-Unsubscribe: <http://lists.gentoo.org/mailman/listinfo/gentoo-dev>,
	<mailto:gentoo-dev-request@gentoo.org?subject=unsubscribe>
List-Archive: <http://lists.gentoo.org/pipermail/gentoo-dev/>
X-Archives-Salt: b9e1582e-3605-4fc5-baee-6cf07656b84a
X-Archives-Hash: 2d31aa9a67914b6b7d4bfe18eb5b3128

Arcady wrote:

> Someone submitted an ebuild that does not define src_compile()
> explicitely.  The ebuild seems to work fine, but I am not sure whether
> this is acceptable.  My main concern is whether the default
> src_compile() will abort merging a package if configuration or
> compilation step fails.

actually, it won't fail. but i think this a bug in ebuild.sh.
the default src_compile() returns 1 if it fails:

src_compile() { 
        if [ -x ./configure ] ; then
	        econf || return 1
		emake || return 1
	fi
	return 
}

but dyn_compile() is not checking the return value. i think
it should. until this is fixed, though, it is probably better
not to use the default src_compile().

> Personally, I'd prefer an explicit src_compile in every ebuild, but I
> can also see the benefits of reusing code from the default one.

i think it would be nice to reuse the default one if possible.
but if you disagree, then i think the default src_compile() should
be changed to do nothing, otherwise the implication is that people 
should use it.

ryan