[gentoo-dev] src_unpack and patches

[gentoo-dev] src_unpack and patches

[Ryan Shaw]

Hello,

The developer docs say:

	src_unpack: Use this function to unpack your sources and apply 
	patches, and run autoconf/automake/etc. if necessary. By default, 
	unpacks the packages in ${A} and applies ${PF}-gentoo.diff. The 
	default starting directory is ${WORKDIR}.

However, src_unpack just seems to unpack sources: it doesn't
apply the *-gentoo.diff patch automatically. Are the docs old
or is this something intended that hasn't been implemented 
yet?

Ryan

Re: [gentoo-dev] src_unpack and patches

[Chad M. Huneycutt]

Ryan Shaw wrote:
> Hello,
> 
> The developer docs say:
> 
> 	src_unpack: Use this function to unpack your sources and apply 
> 	patches, and run autoconf/automake/etc. if necessary. By default, 
> 	unpacks the packages in ${A} and applies ${PF}-gentoo.diff. The 
> 	default starting directory is ${WORKDIR}.
> 
> However, src_unpack just seems to unpack sources: it doesn't
> apply the *-gentoo.diff patch automatically. Are the docs old
> or is this something intended that hasn't been implemented 
> yet?

I am not sure whether it used to patch and now doesn't or if the patching 
was just never implemented by default.  At any rate, you should report this 
at bugzilla.  You might also mention that the unpack routine is a little 
braindead with respect fo files that are gzipped, but not tarred.


Chad (chadh@gentoo.org)

Re: [gentoo-dev] src_unpack and patches

[Ryan Shaw]

Chad wrote:

> Ryan Shaw wrote:
> > Hello,
> > 
> > The developer docs say:
> > 
> > 	src_unpack: Use this function to unpack your sources and apply 
> > 	patches, and run autoconf/automake/etc. if necessary. By default, 
> > 	unpacks the packages in ${A} and applies ${PF}-gentoo.diff. The 
> > 	default starting directory is ${WORKDIR}.
> > 
> > However, src_unpack just seems to unpack sources: it doesn't
> > apply the *-gentoo.diff patch automatically. Are the docs old
> > or is this something intended that hasn't been implemented 
> > yet?
> 
> I am not sure whether it used to patch and now doesn't or if the patching 
> was just never implemented by default.  At any rate, you should report this 
> at bugzilla.  You might also mention that the unpack routine is a little 
> braindead with respect fo files that are gzipped, but not tarred.

Okay, it is in bugzilla now. I didn't mention the braindeadedness
wrt gzipped files because I don't know specifically what the problem
is, and I don't want to submit a vague report...maybe you could
submit it? :^)

Ryan