[gentoo-dev] automake wrapper bug

[gentoo-dev] automake wrapper bug

[Yannick Koehler]

Hello,

	Actually I found my problem.  The way the aclocal.m4 is generated on my 
machine is like this

	AC_PREREQ([2.13])

	Which the am-wrapper incorrectly parse as being version '[2.' instead of 2.1 
like it should have been.

	So there's a bug in this line which doesn't take into account square 
brackets:

|| (cat_('aclocal.m4') =~ /^\s*AC_PREREQ\(([^\)]{3})[^\)]*\)/m ? $1 : '') gt 
'2.1'

Yannick Koehler

Re: [gentoo-dev] automake wrapper bug

[Martin Schlemmer]

On Sat, 2002-04-20 at 16:50, Yannick Koehler wrote:
> 
> Hello,
> 
> 	Actually I found my problem.  The way the aclocal.m4 is generated on my 
> machine is like this
> 
> 	AC_PREREQ([2.13])
> 
> 	Which the am-wrapper incorrectly parse as being version '[2.' instead of 2.1 
> like it should have been.
> 
> 	So there's a bug in this line which doesn't take into account square 
> brackets:
> 
> || (cat_('aclocal.m4') =~ /^\s*AC_PREREQ\(([^\)]{3})[^\)]*\)/m ? $1 : '') gt 
> '2.1'

I think you should verify this.  You see, if the wrapper
cannot extract 2.1 it should fall back to automake-1.4.

> 
> Yannick Koehler
> _______________________________________________
> gentoo-dev mailing list
> gentoo-dev@gentoo.org
> http://lists.gentoo.org/mailman/listinfo/gentoo-dev
-- 

Martin Schlemmer
Gentoo Linux Developer, Desktop Team Developer
Cape Town, South Africa

Re: [gentoo-dev] automake wrapper bug

[Yannick Koehler]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On April 22, 2002 02:35 pm, Martin Schlemmer wrote:
> On Sat, 2002-04-20 at 16:50, Yannick Koehler wrote:
> > Hello,
> >
> > 	Actually I found my problem.  The way the aclocal.m4 is generated on my
> > machine is like this
> >
> > 	AC_PREREQ([2.13])
> >
> > 	Which the am-wrapper incorrectly parse as being version '[2.' instead of
> > 2.1 like it should have been.
> >
> > 	So there's a bug in this line which doesn't take into account square
> >
> > brackets:
> > || (cat_('aclocal.m4') =~ /^\s*AC_PREREQ\(([^\)]{3})[^\)]*\)/m ? $1 : '')
> > || gt
> >
> > '2.1'
>
> I think you should verify this.  You see, if the wrapper
> cannot extract 2.1 it should fall back to automake-1.4.

I found what was happening but didn't found the proper regexp to replace the 
existing one with as I'm far away from being an expert at Regexp.

Right now if you debug the output of 

(cat_('aclocal.m4') =~ /^\s*AC_PREREQ\(([^\)]{3})[^\)]*\)/m ? $1 : '')

On a file that contain AC_PREREQ([2.13]) you get 

[2.

That's what I got when I did a print of the variable.  This then make gt '2.1' 
true (I don't know why).

- -- 

Yannick Koehler
 
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.6 (GNU/Linux)
Comment: For info see http://www.gnupg.org

iD8DBQE8xFrwfuKOJNEyL1URAl53AJ9d5ddMgc5JsreT3hvawwC1jh5MMQCeNvWW
mCB3Sc+sQbgqDBJcFKuRuuk=
=EPfb
-----END PGP SIGNATURE-----