From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dillon@apollo.backplane.com>
X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-14) on finch.gentoo.org
X-Spam-Level: 
X-Spam-Status: No, score=-0.1 required=5.0 tests=DMARC_NONE,MAILING_LIST_MULTI
	autolearn=unavailable autolearn_force=no version=4.0.0
Received: from apollo.backplane.com (apollo.backplane.com [216.240.41.2])
	by chiba.3jane.net (Postfix) with ESMTP id 81CA820AB13C
	for <gentoo-dev@gentoo.org>; Fri, 22 Mar 2002 14:03:43 -0600 (CST)
Received: (from dillon@localhost)
	by apollo.backplane.com (8.11.6/8.9.1) id g2MJxer63123;
	Fri, 22 Mar 2002 11:59:40 -0800 (PST)
	(envelope-from dillon)
Date: Fri, 22 Mar 2002 11:59:40 -0800 (PST)
From: Matthew Dillon <dillon@apollo.backplane.com>
Message-Id: <200203221959.g2MJxer63123@apollo.backplane.com>
To: "Christian HOFFMANN" <christian.hoffmann@noos.fr>
Cc: gentoo-dev@gentoo.org
Subject: Re: [gentoo-dev] Re: [BUG and PATCH] Does dcron need a space at the end of each
References:  <3C9A51D7.13213.459829@localhost>
Sender: gentoo-dev-admin@gentoo.org
Errors-To: gentoo-dev-admin@gentoo.org
X-BeenThere: gentoo-dev@gentoo.org
X-Mailman-Version: 2.0.6
Precedence: bulk
Reply-To: gentoo-dev@gentoo.org
List-Help: <mailto:gentoo-dev-request@gentoo.org?subject=help>
List-Post: <mailto:gentoo-dev@gentoo.org>
List-Subscribe: <http://lists.gentoo.org/mailman/listinfo/gentoo-dev>,
	<mailto:gentoo-dev-request@gentoo.org?subject=subscribe>
List-Id: Gentoo Linux developer list <gentoo-dev.gentoo.org>
List-Unsubscribe: <http://lists.gentoo.org/mailman/listinfo/gentoo-dev>,
	<mailto:gentoo-dev-request@gentoo.org?subject=unsubscribe>
List-Archive: <http://lists.gentoo.org/pipermail/gentoo-dev/>
X-Archives-Salt: a2b1305d-000c-42ff-be24-e0bdab8a2fbe
X-Archives-Hash: 8dc0618344431369adc88438a9530309

:
:I tested your proposed modification, it works far better than mine.
:
:I was just wrong in the beginning, my problem was lines starting with a 
:space (for allignment purpose) and my patch break the others tasks on 
:lines not starting with a space.
:
:Now dcron work for lines starting or not with a space or tabs or...
:
:For your information dcron2.7 is the standard cron for the Gentoo 
:Linux distribution. http://www.gentoo.org

    Ok.  I have updated the master code on my site, which you can get to
    via:

	http://apollo.backplane.com/FreeSrc/

    I can't test it under Linux so its up to you folks to download it,
    compare it with the version you are distributing now, test it, and 
    so forth.  I have included the meat of the bug fix below.

							-Matt

Index: database.c
===================================================================
RCS file: /cvs/dcron/database.c,v
retrieving revision 1.1
retrieving revision 1.2
diff -u -r1.1 -r1.2
--- database.c	10 Feb 1999 06:22:37 -0000	1.1
+++ database.c	22 Mar 2002 17:56:55 -0000	1.2
@@ -174,7 +174,7 @@
 			++ptr;
 
 		    if (*ptr)
-			buf[strlen(ptr)-1] = 0;
+			ptr[strlen(ptr)-1] = 0;
 
 		    if (*ptr == 0 || *ptr == '#')
 			continue;