From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-14) on finch.gentoo.org X-Spam-Level: * X-Spam-Status: No, score=1.3 required=5.0 tests=DKIM_ADSP_ALL,DMARC_QUAR, MAILING_LIST_MULTI autolearn=no autolearn_force=no version=4.0.0 Received: from no-spam.it.helsinki.fi (NO-SPAM.it.helsinki.fi [128.214.205.34]) by chiba.3jane.net (Postfix) with ESMTP id 51A48200AD52 for ; Tue, 5 Feb 2002 01:20:59 -0600 (CST) Received: from mat-153.math.helsinki.fi (mat-153.math.helsinki.fi [128.214.72.113]) by no-spam.it.helsinki.fi (8.11.4/8.11.4-SPAMmers-sod-off) with ESMTP id g157K1413186 for ; Tue, 5 Feb 2002 09:20:01 +0200 (EET) Received: from ekarttun by mat-153.math.helsinki.fi with local (Exim 3.33 #1) id 16Xzs5-0004FK-00 for gentoo-dev@gentoo.org; Tue, 05 Feb 2002 09:18:29 +0200 Date: Tue, 5 Feb 2002 09:18:29 +0200 From: Einar Karttunen To: gentoo-dev@gentoo.org Subject: Re: [gentoo-dev] Is it acceptable to use 'sed' in ebuild scripts? Message-ID: <20020205071829.GA7427@shellak.helsinki.fi> Mail-Followup-To: gentoo-dev@gentoo.org References: <20020205074151.538ab331.bob@evil-core.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20020205074151.538ab331.bob@evil-core.com> User-Agent: Mutt/1.3.25i Sender: gentoo-dev-admin@gentoo.org Errors-To: gentoo-dev-admin@gentoo.org X-BeenThere: gentoo-dev@gentoo.org X-Mailman-Version: 2.0.6 Precedence: bulk Reply-To: gentoo-dev@gentoo.org List-Help: List-Post: List-Subscribe: , List-Id: Gentoo Linux developer list List-Unsubscribe: , List-Archive: X-Archives-Salt: 70ec475a-2be0-4882-8093-57e4ca2a16b1 X-Archives-Hash: 63670e7d92dc2c35876b8efee76e0b23 On 05.02.02 07:41 -0500(+0000), Bob Phan wrote: > Hello, I've just recently created an ebuild for nethack (put it in > app-games/nethack), however, it's build does not use the standard GNU > autoconf/automake system, but rather forces you to manually edit a config.h > file. Currently, I have just made a patch for X support that is applied when > you "use X". I would like to add Qt and GNOME optional support, but using > patches, it is very difficult to have one without the other, or the context > will not match (very messy). I was instead wondering if using 'sed' within > ebuild scripts was accepted practice, or if I should stick a dependancy for > sed at the top of the file. Yes, many ebuilds use sed find /usr/portage/ -name '*ebuild' -exec grep -l 'sed -e' '{}' ';' 2>/dev/null|cut -d/ -f-5|uniq|wc -l 300 So I don't think it will be banned in the near future. > Thanks for any help. I plan on writing a few more (hopefully more trivial) > ebuild scripts for any other software I run across. Also, where should I > submit the ebuild after it's ready? bugs.gentoo.org - Einar Karttunen