From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-14) on finch.gentoo.org X-Spam-Level: X-Spam-Status: No, score=0.2 required=5.0 tests=DATE_IN_PAST_12_24, INVALID_DATE,MAILING_LIST_MULTI,NO_RELAYS autolearn=no autolearn_force=no version=4.0.0 Received: from drobbins by cvs.gentoo.org with local (Exim 3.30 #1) id 15JdN4-0005ev-00 for gentoo-dev@cvs.gentoo.org; Mon, 09 Jul 2001 09:54:50 -0600 From: Daniel Robbins To: gentoo-dev@cvs.gentoo.org Subject: Re: [gentoo-dev] New version of heroes ebuild Message-ID: <20010709095449.C14752@cvs.gentoo.org> References: <01070914195900.00558@localhost> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <01070914195900.00558@localhost>; from ermak@netvision.net.il on Mon, Jul 09, 2001 at 02:19:59PM +0300 Sender: gentoo-dev-admin@cvs.gentoo.org Errors-To: gentoo-dev-admin@cvs.gentoo.org X-BeenThere: gentoo-dev@cvs.gentoo.org X-Mailman-Version: 2.0 Precedence: bulk Reply-To: gentoo-dev@cvs.gentoo.org List-Help: List-Post: List-Subscribe: , List-Id: Gentoo Linux development list List-Unsubscribe: , List-Archive: Date: Mon Jul 9 09:55:02 2001 X-Original-Date: Mon, 9 Jul 2001 09:54:50 -0600 X-Archives-Salt: 684720fa-be3c-4361-8b3a-791cce155def X-Archives-Hash: b80136b670a50d7337496c3d5a30c81e On Mon, Jul 09, 2001 at 02:19:59PM +0300, Dan Armak wrote: > The original version I posted installed a file into /doc: a very strange > default on the part of the makefile. The ebuild now passes a special paramter > to configure to make it install into /usr/share/doc/${P} as needed. > > DEPEND="virtual/x11" > > if [ "`use sdl`" ]; then > DEPEND="${DEPEND} media-libs/libsdl media-libs/sdl-mixer" > confopts="${confopts} --with-sdl --with-sdl-mixer" > else # `use ggi` isn't checked since this is the game's default > DEPEND="${DEPEND} media-libs/libggi media-libs/libgii > media-libs/libmikmod" > confopts="${confopts} --with-ggi --with-mikmod" > fi > > DEPEND="media-libs/libsdl media-libs/sdl-mixer virtual/x11" OK, some notes. First, notice that you just overwrote your DEPEND settings with this line above, so any DEPEND tweaking you did previously was lost. Did you mean to use RDEPEND instead? If so, it defaults to be the same a DEPEND if not defined. Next, you can use our handy DEPEND/RDEPEND syntax to do stuff like this: DEPEND="virtual/x11 sdl? ( media-libs/libsdl media-libs/sdl-mixer ) ggi? ( media-libs/libggi media-libs/libgii )" Also, it may not be good to use sdl *or* libggi. Can one compile-in both options? If not, then the best approach (taking into account the current functionality of the ebuild system) is to create two packages: heroes-sdl and heroes-ggi. Right now, there's no good way for Portage to choose between two existing USE variables; ie. if ggi and sdl are defined, Portage has no way of knowing which one should be preferred. > src_unpack() { > > unpack ${A1} ${A2} ${A3} ${A4} > > } The default src_unpack function should perform this step for you, so you should be able to remove the src_unpack() function from your ebuild. Also, the preferred way of doing things now is to remove the A= definition from your ebuild and just use SRC_URI: SRC_URI="http://prdownloads.sourceforge.net/heroes/heroes-0.11.tar.gz http://prdownloads.sourceforge.net/heroes/heroes-data-1.1.tar.gz http://prdownloads.sourceforge.net/heroes/heroes-sound-tracks-1.0.tar.gz http://prdownloads.sourceforge.net/heroes/heroes-sound-effects-1.0.tar.gz" Other than that, it looks good and I look forward to playing it soon! :) -- Daniel Robbins President/CEO http://www.gentoo.org Gentoo Technologies, Inc.