From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id C81A7158086 for ; Thu, 9 Dec 2021 15:04:31 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id BF9192BC00B; Thu, 9 Dec 2021 15:04:25 +0000 (UTC) Received: from smtp.gentoo.org (woodpecker.gentoo.org [140.211.166.183]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 459A32BC002 for ; Thu, 9 Dec 2021 15:04:24 +0000 (UTC) Message-ID: <1f731fd5d6309bf1ebeb8e08b73ca903a1bc47dc.camel@gentoo.org> Subject: Re: [gentoo-dev] [PATCH 1/5] gnome2-utils.eclass: phase out emktemp From: =?UTF-8?Q?Micha=C5=82_G=C3=B3rny?= To: gentoo-dev@lists.gentoo.org Date: Thu, 09 Dec 2021 16:04:19 +0100 In-Reply-To: <20211209132325.297913-2-marecki@gentoo.org> References: <20211209132325.297913-1-marecki@gentoo.org> <20211209132325.297913-2-marecki@gentoo.org> Organization: Gentoo Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.42.1 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Archives-Salt: cbe3dc73-f0bb-45af-ac20-a89ac43adbb8 X-Archives-Hash: 6c7505ffc7117234fdc5d56b22461df0 On Thu, 2021-12-09 at 13:23 +0000, Marek Szuba wrote: > Has been deprecated for quite a while now, comes from eutils.eclass > so it blocks EAPI 8+. Just call mktemp directly. > > Signed-off-by: Marek Szuba > --- > eclass/gnome2-utils.eclass | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-) > > diff --git a/eclass/gnome2-utils.eclass b/eclass/gnome2-utils.eclass > index f7d45090f82..39c4797eedf 100644 > --- a/eclass/gnome2-utils.eclass > +++ b/eclass/gnome2-utils.eclass > @@ -1,4 +1,4 @@ > -# Copyright 1999-2020 Gentoo Authors > +# Copyright 1999-2021 Gentoo Authors > # Distributed under the terms of the GNU General Public License v2 > > # @ECLASS: gnome2-utils.eclass > @@ -16,10 +16,9 @@ > # * scrollkeeper (old Gnome help system) management > > [[ ${EAPI} == 5 ]] && inherit multilib > -# eutils.eclass: emktemp > # toolchain-funs.eclass: tc-is-cross-compiler > # xdg-utils.eclass: xdg_environment_reset, xdg_icon_cache_update > -inherit eutils toolchain-funcs xdg-utils > +inherit toolchain-funcs xdg-utils > > case ${EAPI} in > 5|6|7) ;; > @@ -379,7 +378,7 @@ gnome2_gdk_pixbuf_update() { > fi > > ebegin "Updating gdk-pixbuf loader cache" > - local tmp_file=$(emktemp) > + local tmp_file=$(mktemp "${T}"/tmp.XXXXXXXXXX) || die "Failed to create temporary file" Why do you need to use random name in the first place? We have full control over T, so why not just hardcode a good name? > ${updater} 1> "${tmp_file}" && > chmod 0644 "${tmp_file}" && > cp -f "${tmp_file}" "${EROOT%/}/usr/$(get_libdir)/gdk-pixbuf-2.0/2.10.0/loaders.cache" && -- Best regards, Michał Górny