Re: [gentoo-dev] [PATCH 1/5] gnome2-utils.eclass: phase out emktemp

["Michał Górny" <mgorny@gentoo.org>]

On Thu, 2021-12-09 at 13:23 +0000, Marek Szuba wrote:
> Has been deprecated for quite a while now, comes from eutils.eclass
> so it blocks EAPI 8+. Just call mktemp directly.
> 
> Signed-off-by: Marek Szuba <marecki@gentoo.org>
> ---
>  eclass/gnome2-utils.eclass | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)
> 
> diff --git a/eclass/gnome2-utils.eclass b/eclass/gnome2-utils.eclass
> index f7d45090f82..39c4797eedf 100644
> --- a/eclass/gnome2-utils.eclass
> +++ b/eclass/gnome2-utils.eclass
> @@ -1,4 +1,4 @@
> -# Copyright 1999-2020 Gentoo Authors
> +# Copyright 1999-2021 Gentoo Authors
>  # Distributed under the terms of the GNU General Public License v2
>  
>  # @ECLASS: gnome2-utils.eclass
> @@ -16,10 +16,9 @@
>  #  * scrollkeeper (old Gnome help system) management
>  
>  [[ ${EAPI} == 5 ]] && inherit multilib
> -# eutils.eclass: emktemp
>  # toolchain-funs.eclass: tc-is-cross-compiler
>  # xdg-utils.eclass: xdg_environment_reset, xdg_icon_cache_update
> -inherit eutils toolchain-funcs xdg-utils
> +inherit toolchain-funcs xdg-utils
>  
>  case ${EAPI} in
>  	5|6|7) ;;
> @@ -379,7 +378,7 @@ gnome2_gdk_pixbuf_update() {
>  	fi
>  
>  	ebegin "Updating gdk-pixbuf loader cache"
> -	local tmp_file=$(emktemp)
> +	local tmp_file=$(mktemp "${T}"/tmp.XXXXXXXXXX) || die "Failed to create temporary file"

Why do you need to use random name in the first place?  We have full
control over T, so why not just hardcode a good name?

>  	${updater} 1> "${tmp_file}" &&
>  	chmod 0644 "${tmp_file}" &&
>  	cp -f "${tmp_file}" "${EROOT%/}/usr/$(get_libdir)/gdk-pixbuf-2.0/2.10.0/loaders.cache" &&

-- 
Best regards,
Michał Górny