From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id CF985158064 for ; Thu, 9 May 2024 12:00:55 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 7E3D1E2B0D; Thu, 9 May 2024 12:00:53 +0000 (UTC) Received: from smtp.gentoo.org (woodpecker.gentoo.org [140.211.166.183]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 13C89E2AF3 for ; Thu, 9 May 2024 12:00:53 +0000 (UTC) Message-ID: <1dd1aa1f46c11051951a63a8987195cda4b0cdf9.camel@gentoo.org> Subject: Re: [gentoo-dev] [PATCH 1/4] acct-user.eclass: make ACCT_USER_NAME writable From: =?UTF-8?Q?Micha=C5=82_G=C3=B3rny?= To: gentoo-dev@lists.gentoo.org Date: Thu, 09 May 2024 14:00:47 +0200 In-Reply-To: <20240509115745.5182-2-mjo@gentoo.org> References: <20240509115745.5182-1-mjo@gentoo.org> <20240509115745.5182-2-mjo@gentoo.org> Organization: Gentoo Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-NTht5qg26bHp0ym7SWSj" User-Agent: Evolution 3.52.1 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply MIME-Version: 1.0 X-Archives-Salt: 5cadd100-42a1-42ad-a5f2-5779cb0c2a5b X-Archives-Hash: 515e0cea4cb750a6db2824803ae50d72 --=-NTht5qg26bHp0ym7SWSj Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, 2024-05-09 at 07:57 -0400, Michael Orlitzky wrote: > The ACCT_USER_NAME variable is set to $PN by Gentoo policy. Prior to > this commit, it was also marked "readonly", preventing it from being > changed in an ebuild. In an overlay, and combined with the package > naming restrictions in the PMS, this has the unfortunate side effect of > prohibiting some otherwise-valid usernames. We drop the "readonly" to > allow those users to be managed (in overlays) using GLEP81 packages. >=20 > Signed-off-by: Michael Orlitzky > --- > eclass/acct-user.eclass | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-) >=20 > diff --git a/eclass/acct-user.eclass b/eclass/acct-user.eclass > index 66a4d6667888..a4fe5e9f5e34 100644 > --- a/eclass/acct-user.eclass > +++ b/eclass/acct-user.eclass > @@ -1,4 +1,4 @@ > -# Copyright 2019-2023 Gentoo Authors > +# Copyright 2019-2024 Gentoo Authors > # Distributed under the terms of the GNU General Public License v2 > =20 > # @ECLASS: acct-user.eclass > @@ -58,12 +58,11 @@ inherit user-info > # << Eclass variables >> > =20 > # @ECLASS_VARIABLE: ACCT_USER_NAME > -# @INTERNAL > # @DESCRIPTION: > # The name of the user. This is forced to ${PN} and the policy prohibit= s > -# it from being changed. > +# it from being changed. The variable is left writable for use in overla= ys; > +# package naming restrictions would prohibit some otherwise-valid userna= mes. You're not following the original style (double spaces). > ACCT_USER_NAME=3D${PN} > -readonly ACCT_USER_NAME > =20 > # @ECLASS_VARIABLE: ACCT_USER_ID > # @REQUIRED --=20 Best regards, Micha=C5=82 G=C3=B3rny --=-NTht5qg26bHp0ym7SWSj Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- iQFGBAABCgAwFiEEx2qEUJQJjSjMiybFY5ra4jKeJA4FAmY8uu8SHG1nb3JueUBn ZW50b28ub3JnAAoJEGOa2uIyniQOQdQH/2iZ55lxYmhlEtSQjbV4CJZO2vpe4BdK 3SqjaEcVIWRwjTggNtwy8lWvJPWUKczcaqjEN/knJ6FGAAsseE7az1wE1wIFPQ5d FUFX9UNrKLJfSPHBn/ZTB0YGzFvQJlRAcX3jleCma+z2czPEQ9R9n515QCawymsG JSpysaLhvcYRQL6WgtnU72+2QnpJq2zVHetZ9T3PJ9CltZ4rjqkZzcyNDOq+0tU9 RtBThLxof60x/GWv7oYS8qTd03UPP8F3hwT+faRvmBeI1uHTBTam2cPzRO/GEJCn 3kMS0zoPJtQPHMN3jv+zh/y6Ga559j93iMQX+mRPcDCR69a8+JvHOpg= =s8lS -----END PGP SIGNATURE----- --=-NTht5qg26bHp0ym7SWSj--