From: "Michał Górny" <mgorny@gentoo.org>
To: gentoo-dev@lists.gentoo.org
Subject: Re: [gentoo-dev] [PATCH 1/4] acct-user.eclass: make ACCT_USER_NAME writable
Date: Thu, 09 May 2024 14:00:47 +0200 [thread overview]
Message-ID: <1dd1aa1f46c11051951a63a8987195cda4b0cdf9.camel@gentoo.org> (raw)
In-Reply-To: <20240509115745.5182-2-mjo@gentoo.org>
[-- Attachment #1: Type: text/plain, Size: 1668 bytes --]
On Thu, 2024-05-09 at 07:57 -0400, Michael Orlitzky wrote:
> The ACCT_USER_NAME variable is set to $PN by Gentoo policy. Prior to
> this commit, it was also marked "readonly", preventing it from being
> changed in an ebuild. In an overlay, and combined with the package
> naming restrictions in the PMS, this has the unfortunate side effect of
> prohibiting some otherwise-valid usernames. We drop the "readonly" to
> allow those users to be managed (in overlays) using GLEP81 packages.
>
> Signed-off-by: Michael Orlitzky <mjo@gentoo.org>
> ---
> eclass/acct-user.eclass | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/eclass/acct-user.eclass b/eclass/acct-user.eclass
> index 66a4d6667888..a4fe5e9f5e34 100644
> --- a/eclass/acct-user.eclass
> +++ b/eclass/acct-user.eclass
> @@ -1,4 +1,4 @@
> -# Copyright 2019-2023 Gentoo Authors
> +# Copyright 2019-2024 Gentoo Authors
> # Distributed under the terms of the GNU General Public License v2
>
> # @ECLASS: acct-user.eclass
> @@ -58,12 +58,11 @@ inherit user-info
> # << Eclass variables >>
>
> # @ECLASS_VARIABLE: ACCT_USER_NAME
> -# @INTERNAL
> # @DESCRIPTION:
> # The name of the user. This is forced to ${PN} and the policy prohibits
> -# it from being changed.
> +# it from being changed. The variable is left writable for use in overlays;
> +# package naming restrictions would prohibit some otherwise-valid usernames.
You're not following the original style (double spaces).
> ACCT_USER_NAME=${PN}
> -readonly ACCT_USER_NAME
>
> # @ECLASS_VARIABLE: ACCT_USER_ID
> # @REQUIRED
--
Best regards,
Michał Górny
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 512 bytes --]
next prev parent reply other threads:[~2024-05-09 12:00 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-09 11:57 [gentoo-dev] [PATCH 0/4] acct-{user,group}.eclass: make user/group names writable Michael Orlitzky
2024-05-09 11:57 ` [gentoo-dev] [PATCH 1/4] acct-user.eclass: make ACCT_USER_NAME writable Michael Orlitzky
2024-05-09 12:00 ` Michał Górny [this message]
2024-05-10 5:58 ` Ulrich Mueller
2024-05-09 11:57 ` [gentoo-dev] [PATCH 2/4] acct-group.eclass: make ACCT_GROUP_NAME writable Michael Orlitzky
2024-05-09 11:57 ` [gentoo-dev] [PATCH 3/4] acct-user.eclass: use an eclass variable for the override variable name Michael Orlitzky
2024-05-09 12:03 ` Michał Górny
2024-05-09 12:12 ` Michael Orlitzky
2024-05-09 12:41 ` Michał Górny
2024-05-09 11:57 ` [gentoo-dev] [PATCH 4/4] acct-group.eclass: " Michael Orlitzky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1dd1aa1f46c11051951a63a8987195cda4b0cdf9.camel@gentoo.org \
--to=mgorny@gentoo.org \
--cc=gentoo-dev@lists.gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox