Re: [gentoo-dev] [PATCH 1/5] out-of-source-utils.eclass: New utility eclass

["Michał Górny" <mgorny@gentoo.org>]

On Mon, 2023-01-02 at 10:25 +0100, Ulrich Mueller wrote:
> > > > > > On Sun, 01 Jan 2023, Michał Górny wrote:
> 
> > +case ${EAPI} in
> > +	6|7|8) ;;
> > +	*) die "${ECLASS}: EAPI ${EAPI} unsupported."
> 
> Are you sure that this will work without the final ;; terminator?
> (Bash documentation says that a terminator is mandatory.)

Interesting enough, it does work.

> Apart from that, I'd suggest to use the standard clause as in other
> eclasses:
> 
> 	*) die "${ECLASS}: EAPI ${EAPI:-0} not supported" ;;
> 

Actually, this is what app-vim/gentoo-syntax spews by default.  I guess
I need to change it.

Anyway, replaced by your snippet.  I suppose it's fine if I don't
resubmit the batch for this change.

-- 
Best regards,
Michał Górny