From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pigeon.gentoo.org ([208.92.234.80] helo=lists.gentoo.org) by finch.gentoo.org with esmtp (Exim 4.60) (envelope-from ) id 1NRNiT-0003V2-F3 for garchives@archives.gentoo.org; Sun, 03 Jan 2010 10:29:45 +0000 Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 6F99FE060F; Sun, 3 Jan 2010 10:28:54 +0000 (UTC) Received: from a1iwww1.kph.uni-mainz.de (a1iwww1.kph.uni-mainz.de [134.93.134.1]) by pigeon.gentoo.org (Postfix) with ESMTP id 18880E0636 for ; Sun, 3 Jan 2010 10:28:53 +0000 (UTC) Received: from a1i15.kph.uni-mainz.de (a1i15.kph.uni-mainz.de [134.93.134.92]) by a1iwww1.kph.uni-mainz.de (8.14.0/8.13.4) with ESMTP id o03ASqfe029678 for ; Sun, 3 Jan 2010 11:28:52 +0100 Received: from a1i15.kph.uni-mainz.de (localhost [127.0.0.1]) by a1i15.kph.uni-mainz.de (8.14.3/8.14.2) with ESMTP id o03ASpV3030482; Sun, 3 Jan 2010 11:28:51 +0100 Received: (from ulm@localhost) by a1i15.kph.uni-mainz.de (8.14.3/8.14.3/Submit) id o03ASpWi030479; Sun, 3 Jan 2010 11:28:51 +0100 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Message-ID: <19264.29027.852829.477540@a1i15.kph.uni-mainz.de> Date: Sun, 3 Jan 2010 11:28:51 +0100 To: gentoo-dev@lists.gentoo.org Subject: Re: [gentoo-dev] Re: [RFC] base.eclass In-Reply-To: <20100103062307.GA13558@boostbox> References: <4B3F6BB5.1030703@gentoo.org> <4B3FF949.40901@gentoo.org> <20100103062307.GA13558@boostbox> X-Mailer: VM 8.0.12 under 23.1.1 (x86_64-pc-linux-gnu) From: Ulrich Mueller Content-Transfer-Encoding: quoted-printable X-Archives-Salt: e3256051-4137-4670-844b-24d8ab31add8 X-Archives-Hash: df6eb7e1114b4ed5d0ef348b2f947968 >>>>> On Sun, 3 Jan 2010, Harald van D=C4=B3k wrote: >> > 65 base_src_util $@ >> This is not problem > Only because you can be sure there will be exactly one word in the > result, which will not be split. In general, $@ should be quoted, and i= t > would be a good idea to either do it here too even though it's not > strictly necessary, or make the intent clearer and just write > base_src_util $1 I think this would not be correct. Note the while loop over parameters in base_src_util. So it should be "$@" (with quotes). >> > 90 case $1 in >> Yarp this is problem and fixed > That's not a problem. A case expression is another example where > quoting is unnecessary; there won't be any word splitting on $1 > anyway. Right, so you should remove these quotes again. >> > 95 [[ ! -z "${A}" ]] && unpack ${A} >> ${A} is not used quoted :] > Right, that doesn't need quoting, and it would even be okay to drop > the unnecessary quotes in [[. s/it would even be okay to/you should/ Only cases where you need quotes inside [[ ]] are: 1. whitespace or special characters that must be quoted, 2. suppress pattern matching for the right hand side of an =3D=3D or !=3D expression. Ulrich