Re: [gentoo-dev] Re: [RFC] base.eclass

[Ulrich Mueller <ulm@gentoo.org>]

>>>>> On Sun, 3 Jan 2010, Harald van Dijk wrote:

>> > 65                 base_src_util $@
>> This is not problem

> Only because you can be sure there will be exactly one word in the
> result, which will not be split. In general, $@ should be quoted, and it
> would be a good idea to either do it here too even though it's not
> strictly necessary, or make the intent clearer and just write

>   base_src_util $1

I think this would not be correct. Note the while loop over parameters
in base_src_util. So it should be "$@" (with quotes).

>> > 90                 case $1 in
>> Yarp this is problem and fixed

> That's not a problem. A case expression is another example where
> quoting is unnecessary; there won't be any word splitting on $1
> anyway.

Right, so you should remove these quotes again.

>> > 95                                 [[ ! -z "${A}" ]] && unpack ${A}
>> ${A} is not used quoted :]

> Right, that doesn't need quoting, and it would even be okay to drop
> the unnecessary quotes in [[.

s/it would even be okay to/you should/

Only cases where you need quotes inside [[ ]] are:
1. whitespace or special characters that must be quoted,
2. suppress pattern matching for the right hand side of an == or !=
   expression.

Ulrich