From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 81C85138334 for ; Tue, 24 Dec 2019 22:02:44 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 51380E0E2F; Tue, 24 Dec 2019 22:02:41 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id BABB4E0E2A for ; Tue, 24 Dec 2019 22:02:40 +0000 (UTC) Received: from pomiot (c142-245.icpnet.pl [85.221.142.245]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: mgorny) by smtp.gentoo.org (Postfix) with ESMTPSA id 0F41334DB10; Tue, 24 Dec 2019 22:02:38 +0000 (UTC) Message-ID: <18e06c3284946f7e06b62e874afa9c5c4ba1e2e9.camel@gentoo.org> Subject: Re: [gentoo-dev] [RFC] New eclass patches.eclass From: =?UTF-8?Q?Micha=C5=82_G=C3=B3rny?= To: gentoo-dev@lists.gentoo.org Date: Tue, 24 Dec 2019 23:02:33 +0100 In-Reply-To: <3239051.CDrfBSqNs1@note> References: <3239051.CDrfBSqNs1@note> Organization: Gentoo Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-v/54McGij+mIRJA+7vkT" User-Agent: Evolution 3.32.5 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply MIME-Version: 1.0 X-Archives-Salt: 015198e2-e3c6-45ee-85bb-a1bc26cd6971 X-Archives-Hash: 1b5cd203a6d03099d4d1f93640566ce2 --=-v/54McGij+mIRJA+7vkT Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Sun, 2019-12-22 at 16:39 +0700, Vadim A. Misbakh-Soloviov wrote: > HI there! >=20 > Some time ago I invented patches.eclass, which facilitates my work with= =20 > patches, and I would like you to express your opinion about it and whethe= r it=20 > is worth committing in gentoo repo. >=20 > Maybe it=E2=80=99s even worth it to become a helper, but not an eclass, o= r be bundled=20 > somewhere in existing eclasses/helpers. >=20 No. This is just awful implicit magic. While I understand that you believe it makes the work easier for *you* but you are not going to be the only person ever to touch ebuilds you are maintaining today. You are talking of creating a complex directory structure which might or might not affect every ebuild, in hardly predictable ways. Sometimes you won't be able to fit a patch in any of the categories.=20 Then you're going to needlessly duplicate it in multiple directories, triggering CI warnings for duplicate files. Sometimes you will have to jump through hoops to change patching order, so that every subdirectory works correctly. Grepping the ebuilds for applicable files from FILESDIR just won't work. Sure, maybe the proposed structure will be more convenient for cleanup.=20 Unless people accidentally remove whole FILESDIR because they don't see any reference to it. Until this is widely deployed (which is unlikely to happen), people will get very confused over every ebuild using it. Finally, this can only bring real gain if you carry a lot of patches.=20 In that case, I'd really prefer if you put them into a tarball, and into SRC_URI rather than polluting all the Gentoo installations. --=20 Best regards, Micha=C5=82 G=C3=B3rny --=-v/54McGij+mIRJA+7vkT Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iQGTBAABCgB9FiEEx2qEUJQJjSjMiybFY5ra4jKeJA4FAl4CivpfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldEM3 NkE4NDUwOTQwOThEMjhDQzhCMjZDNTYzOUFEQUUyMzI5RTI0MEUACgkQY5ra4jKe JA5mWwf/WH17loy9fPMezJx4MQVknEx4MNeeJtPF0pK9HsU30rBFZDTvJCiXnU9T 9Z0pBMt6EHaxw5VccAnc1zy1/ekpU7FAmVMX05570cLuLTs//A0MWLJtpXqaK85r GrS03IrQMB0h/vxWJwD5O1lh/diWNap/iHEDEBQkfaTG+kMVB0WLXVkGj4PzIWrt 2HH6mWsN7FJD74ki4DA3BTTne053zN2c63+djMbkzbeEVnuWXlnCnhUv5cEgZNnq +Cz9eShpwXndU3vfDZLX80mqOHDKTr1btdE5RKzm5eWx7e7W2q7LrddphPw9c3ba shWYecU8K8jUCuFCl4sm9PNBPwT84g== =Kjua -----END PGP SIGNATURE----- --=-v/54McGij+mIRJA+7vkT--