From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pigeon.gentoo.org ([69.77.167.62] helo=lists.gentoo.org) by finch.gentoo.org with esmtp (Exim 4.60) (envelope-from ) id 1KpGwE-0000H6-6M for garchives@archives.gentoo.org; Mon, 13 Oct 2008 06:29:54 +0000 Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 5930DE02CD; Mon, 13 Oct 2008 06:29:52 +0000 (UTC) Received: from a1iwww1.kph.uni-mainz.de (a1iwww1.kph.uni-mainz.de [134.93.134.1]) by pigeon.gentoo.org (Postfix) with ESMTP id 0E360E02CD for ; Mon, 13 Oct 2008 06:29:51 +0000 (UTC) Received: from a1ihome1.kph.uni-mainz.de (a1ihome1.kph.uni-mainz.de [134.93.134.75]) by a1iwww1.kph.uni-mainz.de (8.14.0/8.13.4) with ESMTP id m9D6Tnka016118 for ; Mon, 13 Oct 2008 08:29:50 +0200 Received: from a1ihome1.kph.uni-mainz.de (localhost [127.0.0.1]) by a1ihome1.kph.uni-mainz.de (8.14.0/8.14.1) with ESMTP id m9D6Tnpd029814; Mon, 13 Oct 2008 08:29:49 +0200 Received: (from ulm@localhost) by a1ihome1.kph.uni-mainz.de (8.14.0/8.14.0/Submit) id m9D6TnE7029809; Mon, 13 Oct 2008 08:29:49 +0200 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <18674.60125.318827.567899@a1ihome1.kph.uni-mainz.de> Date: Mon, 13 Oct 2008 08:29:49 +0200 To: gentoo-dev@lists.gentoo.org Subject: [gentoo-dev] Re: bzr.eclass into Portage In-Reply-To: References: <20080317193133.525ba4ab@gentoo.org> <47DF0EB6.8010300@gentoo.org> <47E0994D.20705@gentoo.org> <20080320083853.65c20275@gentoo.org> <47E32FDE.60805@gentoo.org> <20080321124913.00d96832@gentoo.org> <18664.63712.432021.661712@a1ihome1.kph.uni-mainz.de> <48E962B7.2000403@gentoo.org> <18665.44245.631670.638507@a1ihome1.kph.uni-mainz.de> X-Mailer: VM 8.0.2-487 under Emacs 22.2.1 (i686-pc-linux-gnu) From: Ulrich Mueller X-Archives-Salt: b1520141-ba18-4097-81fc-cf86e62f7c3f X-Archives-Hash: eab51bf664299c1760a406cced6ada81 >>>>> On Mon, 13 Oct 2008, Steve Long wrote: > No objections, a minor point wrt bash: > EBZR_OPTIONS="${EBZR_OPTIONS:-}" (and similar variants) > doesn't do anything (beyond waste lex and yacc time.) It does something, namely assigns an empty string if the variable was undefined before. ;-) git.eclass and mercurial.eclass do : ${EGIT_OPTIONS:=} which has the same effect. I've left these statements in for now, since I don't see how they could harm. Does anyone else have an opinion here? I'm not really decided about this point. > [[ -z ${EBZR_REPO_URI} ]] && die .. > Here's how I'd write that: > [[ $EBZR_REPO_URI ]] || die .. Applied. (However, I didn't remove the curly braces which are Gentoo "house style".) > I've heard the "be explicit" argument before (hey antarus;) and > here's why I disagree: > If you don't know test (''help test'') and what its default is, then > you really don't know the basics of shellscript (you possibly only > think you do.) If you don't know shell, and can't begin to > understand what that might do, then you shouldn't consider coding as > a career, and I'd expect you to take quite a while to go through the > #bash crucible; if you ever make it I'd have a lot of time for you. Don't use a sledgehammer to crack a nut. The above is purely a question of coding style and personal preferences. > Given that, is there any reason not to use 1.6 if installed, and > fallback to an earlier version if not? Of course not. The dependency is DEPEND=">=dev-util/bzr-1.5". Ulrich