From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pigeon.gentoo.org ([69.77.167.62] helo=lists.gentoo.org) by finch.gentoo.org with esmtp (Exim 4.60) (envelope-from ) id 1KmPMK-0006Vy-VX for garchives@archives.gentoo.org; Sun, 05 Oct 2008 08:53:01 +0000 Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 65B05E018B; Sun, 5 Oct 2008 08:52:47 +0000 (UTC) Received: from a1iwww1.kph.uni-mainz.de (a1iwww1.kph.uni-mainz.de [134.93.134.1]) by pigeon.gentoo.org (Postfix) with ESMTP id 0E649E018B for ; Sun, 5 Oct 2008 08:52:46 +0000 (UTC) Received: from a1ihome1.kph.uni-mainz.de (a1ihome1.kph.uni-mainz.de [134.93.134.75]) by a1iwww1.kph.uni-mainz.de (8.14.0/8.13.4) with ESMTP id m958qiZ2016522 for ; Sun, 5 Oct 2008 10:52:45 +0200 Received: from a1ihome1.kph.uni-mainz.de (localhost [127.0.0.1]) by a1ihome1.kph.uni-mainz.de (8.14.0/8.14.1) with ESMTP id m958qiJV001694; Sun, 5 Oct 2008 10:52:44 +0200 Received: (from ulm@localhost) by a1ihome1.kph.uni-mainz.de (8.14.0/8.14.0/Submit) id m958qi8K001689; Sun, 5 Oct 2008 10:52:44 +0200 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Message-ID: <18664.32860.348921.385462@a1ihome1.kph.uni-mainz.de> Date: Sun, 5 Oct 2008 10:52:44 +0200 To: gentoo-dev@lists.gentoo.org Subject: Re: [gentoo-dev] Default src_install for EAPI-2 or following EAPI In-Reply-To: <48E25C61.7070805@gentoo.org> References: <18646.45711.173931.589892@a1ihome1.kph.uni-mainz.de> <48D94608.7060805@gentoo.org> <200809240121.04326.bo.andresen@zlin.dk> <8b4c83ad0809240046n20adbeb1gb376db13d79f7bdc@mail.gmail.com> <48DE0825.1010009@gentoo.org> <8b4c83ad0809282216x6f890699t35b93d7efb6dfae5@mail.gmail.com> <48E25C61.7070805@gentoo.org> X-Mailer: VM 8.0.2-487 under Emacs 22.2.1 (i686-pc-linux-gnu) From: Ulrich Mueller Content-Transfer-Encoding: quoted-printable X-Archives-Salt: b9bfda53-cc1b-42e0-b7eb-c2be0d6aa8db X-Archives-Hash: db4ae217b3a8b8a9a951300813ad9598 >>>>> On Tue, 30 Sep 2008, Petteri R=E4ty wrote: >>> dodoc ${DOCS} || die "dodoc failed" >> This seems alright fine to me > It's not. If you want to have default DOCS then you should loop > through the items and check with [[ -e ]] before trying to install > them. I'm not convinced that this is a good idea. Then you won't catch cases where upstream removes or renames files. Besides, dodoc already checks for -e by itself (and emits a warning if the file does not exist). So, maybe just do a 'dodoc "${DOCS}"' and omit the die? Then it won't fail but the warning message would be preserved. Ulrich