public inbox for gentoo-dev@lists.gentoo.org
 help / color / mirror / Atom feed
From: Ulrich Mueller <ulm@gentoo.org>
To: Mike Frysinger <vapier@gentoo.org>
Cc: gentoo-dev@lists.gentoo.org, compnerd@gentoo.org
Subject: Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in app-editors/leafpad: ChangeLog leafpad-0.8.14.ebuild
Date: Sun, 30 Mar 2008 19:07:35 +0200	[thread overview]
Message-ID: <18415.51415.589084.768406@a1ihome1.kph.uni-mainz.de> (raw)
In-Reply-To: <200803301225.25148.vapier@gentoo.org>

>>>>> On Sun, 30 Mar 2008, Mike Frysinger wrote:

>> And IMHO the "emacs" USE flag should not be used here:
>> 
>> $ ./configure -hs
>> Configuration of Leafpad 0.8.12:
>> 
>> Optional Features:
>> [...]
>> --enable-emacs          implement Emacs key theme (experimental)
>> 
>> $ equery uses =leafpad-0.8.12
>> [...]
>> + + emacs : Adds support for GNU Emacs
>> 
>> As its description says, the flag is intended for GNU Emacs support
>> which is not the case here.

> i think the USE flag makes sense. perhaps the description should be
> changed.

Certainly a USE flag makes sense here, but it shouldn't be USE=emacs.

The "emacs" global USE flag is used by 82 other packages (all outside
the app-emacs category). Its purpose is always that GNU Emacs specific
files are installed; either directly, or indirectly by pulling another
package via *DEPEND.

So leafpad would be the first package assigning a different meaning to
the flag.

In my opinion, a local USE flag like "emacskeys" or "emacs-keymap"
would make more sense here. (And I doubt that users who would enable
Emacs key bindings in leafpad would always want GNU Emacs. Setting
USE=emacs in make.conf will inevitably install it.)

Ulrich
-- 
gentoo-dev@lists.gentoo.org mailing list



  reply	other threads:[~2008-03-30 17:07 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <E1Jfgrd-0007H6-7k@stork.gentoo.org>
2008-03-30  5:43 ` [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in app-editors/leafpad: ChangeLog leafpad-0.8.14.ebuild Donnie Berkholz
2008-03-30  6:16   ` Ulrich Mueller
2008-03-30 16:25     ` Mike Frysinger
2008-03-30 17:07       ` Ulrich Mueller [this message]
2008-03-30 17:23         ` Mike Frysinger
2008-03-31  6:26           ` Marijn Schouten (hkBst)
2008-03-31 15:25             ` Mike Frysinger
2008-03-31 16:24               ` Christian Faulhammer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=18415.51415.589084.768406@a1ihome1.kph.uni-mainz.de \
    --to=ulm@gentoo.org \
    --cc=compnerd@gentoo.org \
    --cc=gentoo-dev@lists.gentoo.org \
    --cc=vapier@gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox