From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id C284E138334 for ; Wed, 11 Sep 2019 17:38:32 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id E56C2E0A8D; Wed, 11 Sep 2019 17:38:23 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 49573E0A89 for ; Wed, 11 Sep 2019 17:38:23 +0000 (UTC) Received: from pomiot (c134-66.icpnet.pl [85.221.134.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: mgorny) by smtp.gentoo.org (Postfix) with ESMTPSA id 93EC034B0D0; Wed, 11 Sep 2019 17:38:21 +0000 (UTC) Message-ID: <1839d49b6adcfeba3c807543e0ba01e0f2888a36.camel@gentoo.org> Subject: Re: [gentoo-dev] [PATCH 1/3] go-module.eclass: introduce new eclass to handle go modules From: =?UTF-8?Q?Micha=C5=82_G=C3=B3rny?= To: gentoo-dev@lists.gentoo.org Cc: William Hubbs Date: Wed, 11 Sep 2019 19:38:17 +0200 In-Reply-To: <20190911172128.18885-2-williamh@gentoo.org> References: <20190911172128.18885-1-williamh@gentoo.org> <20190911172128.18885-2-williamh@gentoo.org> Organization: Gentoo Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-jTmBhhX0STqa4aNp/41x" User-Agent: Evolution 3.32.4 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply MIME-Version: 1.0 X-Archives-Salt: e1ae2c29-0e35-4bcb-b8a6-d63b94daba8d X-Archives-Hash: 06d4a98a0becb58fc5ada4a1a8ac1eb3 --=-jTmBhhX0STqa4aNp/41x Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, 2019-09-11 at 12:21 -0500, William Hubbs wrote: > Copyright: Sony Interactive Entertainment Inc. > Signed-off-by: William Hubbs > --- > eclass/go-module.eclass | 76 +++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 76 insertions(+) > create mode 100644 eclass/go-module.eclass >=20 > diff --git a/eclass/go-module.eclass b/eclass/go-module.eclass > new file mode 100644 > index 00000000000..7009fcd3beb > --- /dev/null > +++ b/eclass/go-module.eclass > @@ -0,0 +1,76 @@ > +# Copyright 1999-2015 Gentoo Foundation You need to replace your calendar. And copyright holder. > +# Distributed under the terms of the GNU General Public License v2 > + > +# @ECLASS: go-module.eclass Any reason to change naming from golang-* to go-* now? > +# @MAINTAINER: > +# William Hubbs > +# @SUPPORTED_EAPIS: 7 > +# @BLURB: basic eclass for building software written in the go > +# programming language that uses go modules. > +# @DESCRIPTION: > +# This eclass provides a convenience src_prepare() phase and some basic > +# settings needed for all software written in the go programming > +# language that uses go modules. > +# > +# You will know the software you are packaging uses modules because > +# it will have files named go.sum and go.mod in its top-level source > +# directory. If it does not have these files, use the golang-* eclasses. > +# > +# If the software you are packaging uses modules, the next question is > +# whether it has a directory named "vendor" at the top-level of the sour= ce tree. > +# > +# If it doesn't, you need to create a tarball of what would be in the > +# vendor directory and mirror it locally. This is done with the > +# following commands if upstream is using a git repository: > +# > +# @CODE: > +# > +# $ cd /my/clone/of/upstream > +# $ git checkout > +# $ go mod vendor > +# $ tar cvf project-version-vendor.tar.gz vendor > +# > +# @CODE: > +# > +# Other than this, all you need to do is inherit this eclass then > +# make sure the exported src_prepare function is run. > + > +case ${EAPI:-0} in > + 7) ;; > + *) die "${ECLASS} API in EAPI ${EAPI} not yet established." > +esac > + > +if [[ -z ${_GO_MODULE} ]]; then > + > +_GO_MODULE=3D1 > + > +BDEPEND=3D">=3Ddev-lang/go-1.12" > + > +# Do not download dependencies from the internet > +# make build output verbose by default > +export GOFLAGS=3D"-mod=3Dvendor -v -x" > + > +# Do not complain about CFLAGS etc since go projects do not use them. > +QA_FLAGS_IGNORED=3D'.*' > + > +# Upstream does not support stripping go packages > +RESTRICT=3D"strip" > + > +EXPORT_FUNCTIONS src_prepare Don't you need to inherit some other eclass to make it build? > + > +# @FUNCTION: go-module_src_prepare > +# @DESCRIPTION: > +# Run a default src_prepare then move our provided vendor directory to > +# the appropriate spot if upstream doesn't provide a vendor directory. > +go-module_src_prepare() { > + default > + # Use the upstream provided vendor directory if it exists. > + [[ -d vendor ]] && return > + # If we are not providing a mirror of a vendor directory we created > + # manually, return since there may be nothing to vendor. > + [[ ! -d ../vendor ]] && return > + # At this point, we know we are providing a vendor mirror. > + mv ../vendor . || die "Unable to move ../vendor directory" Wouldn't it be much simpler to create appropriate directory structure in the tarball? Then you wouldn't need a new eclass at all. > +} > + > +fi --=20 Best regards, Micha=C5=82 G=C3=B3rny --=-jTmBhhX0STqa4aNp/41x Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iQGTBAABCgB9FiEEx2qEUJQJjSjMiybFY5ra4jKeJA4FAl15MQlfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldEM3 NkE4NDUwOTQwOThEMjhDQzhCMjZDNTYzOUFEQUUyMzI5RTI0MEUACgkQY5ra4jKe JA4cmAgArsP+CX5V/LfX6Ot8KujV1t5NPWSU2UOOkcFj+5XAvDxCj5rURmWfUPsd EbrDO04SWUsCJnois4RhnJ0zmsn6U/vc4aBowHSHkjEY145vVfEPh0JF5kJPCDdU VmZE2WYrSuiSR7VAmTe6gqav5mKFHE8MaBxygfy6DNvmNNp0efP1tGSq7e0vJg1o HTAjHTx6K8KoFFpLZVJ8yxYMp4YIb9NH1hS0lrfKuziBbaOvOzmygo6+uBwHdvVc RZJTk9NcbQJSGh0ZLTf/FkRfrewQ15OdzYU7Qpe8gBX6IZBFs1TVn05kYl/wvkNV kzn6Jn5/nxJPiJ+SEi+sFarwxfOX9w== =sgG1 -----END PGP SIGNATURE----- --=-jTmBhhX0STqa4aNp/41x--