public inbox for gentoo-dev@lists.gentoo.org
 help / color / mirror / Atom feed
From: Andreas Sturmlechner <asturm@gentoo.org>
To: gentoo-dev@lists.gentoo.org
Cc: "Marty E. Plummer" <hanetzer@startmail.com>
Subject: Re: [gentoo-dev] [PATCH] eclass/java-utils-2: switch to eapi7-ver
Date: Thu, 21 Feb 2019 15:30:32 +0100	[thread overview]
Message-ID: <1801787.GisAbXGV1V@tuxbrain> (raw)
In-Reply-To: <20181217080913.32217-1-hanetzer@startmail.com>

On Montag, 17. Dezember 2018 09:09:13 CET Marty E. Plummer wrote:
> @@ -15,7 +15,7 @@
>  # you should inherit java-pkg-2 for Java packages or java-pkg-opt-2 for
> packages # that have optional Java support. In addition you can inherit
> java-ant-2 for # Ant-based packages.
> -inherit eutils versionator multilib
> +inherit eutils multilib

I would recommend to keep inheriting all those eclasses (including 
versionator) for EAPI 0-6, in order not to break revdeps with implicit use. 
Who knows in what shape they are, and no one is going to fix them for a long 
time. But we don't want to inherit any of them with EAPI-7, hence merge it 
with below hunk.

> @@ -25,6 +25,9 @@ export WANT_JAVA_CONFIG="2"
>  # Prefix variables are only available for EAPI>=3
>  has "${EAPI:-0}" 0 1 2 && ED="${D}" EPREFIX= EROOT="${ROOT}"
> 
> +# EAPI 7 has version functions built-in. Use eapi7-ver for all earlier 
> eclasses.
> +[[ ${EAPI} == [0123456] ]] && inherit eapi7-ver
> +
>  # @VARIABLE: JAVA_PKG_E_DEPEND
>  # @INTERNAL
>  # @DESCRIPTION:


Regards,
Andreas




  reply	other threads:[~2019-02-21 14:31 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-17  8:09 [gentoo-dev] [PATCH] eclass/java-utils-2: switch to eapi7-ver Marty E. Plummer
2019-02-21 14:30 ` Andreas Sturmlechner [this message]
2019-02-23  2:51   ` Marty E. Plummer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1801787.GisAbXGV1V@tuxbrain \
    --to=asturm@gentoo.org \
    --cc=gentoo-dev@lists.gentoo.org \
    --cc=hanetzer@startmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox